CASSANDRA-21092: Automatically disable zero-copy streaming for legacy sstables (5.0)#4544
Closed
pauloricardomg wants to merge 1 commit intoapache:cassandra-5.0from
Closed
CASSANDRA-21092: Automatically disable zero-copy streaming for legacy sstables (5.0)#4544pauloricardomg wants to merge 1 commit intoapache:cassandra-5.0from
pauloricardomg wants to merge 1 commit intoapache:cassandra-5.0from
Conversation
pauloricardomg
force-pushed
the
CASSANDRA-21092-5.0
branch
from
d310abd to
6cd41c3
Compare
pauloricardomg
changed the title
pauloricardomg
force-pushed
the
CASSANDRA-21092-5.0
branch
from
6cd41c3 to
d77a303
Compare
Legacy Cassandra 3.x sstables use an old bloom filter format that is incompatible with zero-copy streaming in Cassandra 5.0+. This patch automatically detects sstables with the old bloom filter format (pre-4.0) and disables zero-copy streaming for them, allowing legacy sstables to be loaded via sstableloader without requiring manual flags. The fix adds a version check in CassandraOutgoingFile.computeShouldStreamEntireSSTables() that calls descriptor.version.hasOldBfFormat() to detect legacy sstables. patch by Paulo Motta; reviewed by Stefan Miklosovic for CASSANDRA-21092
pauloricardomg
force-pushed
the
CASSANDRA-21092-5.0
branch
from
d77a303 to
9cfc84d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy Cassandra 3.x sstables use an old bloom filter format that is
incompatible with zero-copy streaming in Cassandra 5.0+. This patch
automatically detects sstables with the old bloom filter format
(pre-4.0) and disables zero-copy streaming for them, allowing legacy
sstables to be loaded via sstableloader without requiring manual flags.
The fix adds a version check in CassandraOutgoingFile.computeShouldStreamEntireSSTables()
that calls descriptor.version.hasOldBfFormat() to detect legacy sstables.