import-vm: remove username, password request params for vm import#401
Merged
yadvr merged 3 commits intoapache:4.19from Jun 14, 2024
Merged
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
force-pushed
the
fix-note-reqdparams-listvmsforimport
branch
from
5fd3777 to
9ae0f48
Compare
13 tasks
DaanHoogland
approved these changes
May 28, 2024
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
lgtm (when apache/cloudstack#9124 is merged
| @@ -437,8 +437,6 @@ those same credentials are later used for SSH authentication when the QCOW2 imag | |||
| .. parsed-literal:: | |||
| - **zoneid** (Zone to which Instance will be imported) | |||
| - **host** (the host name or IP address of External Host) | |||
Contributor
There was a problem hiding this comment.
need to update the description above, indicating these are optional?
Linux user's username and password are needed for this API call
Contributor
Author
There was a problem hiding this comment.
I don't think adding them even as optional right now gives any benefit as they are completely unused for listing.
Contributor
There was a problem hiding this comment.
correct @shwstppr, remove them - not required for listing
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on apache/cloudstack#8414
📚 Documentation preview 📚: https://cloudstack-documentation--401.org.readthedocs.build/en/401/