[FIX] New Instance dialog by utchoang · Pull Request #401 · apache/cloudstack-primate

utchoang · 2020-06-08T04:18:03Z

Open for #263 and #375 (comment)

Add scroller in the 'New instance' info
Can't "un-choose" the Zone/Pod/Host for the VM deployment

… sections

utchoang · 2020-06-08T09:12:01Z

Add scroller in VM info
Add "Default" option into the select box the Zone/Pod/Host for the VM deployment

utchoang · 2020-06-08T09:12:43Z

@rhtyd cc @svenvogel I've completed. Please review and testing. Thanks.

yadvr · 2020-06-14T00:51:32Z

@utchoang I missed seeing this PR and pushed a fix, can you review my commit and close this PR if my commit fixes the issue:
0468b82

# Conflicts: # src/views/compute/DeployVM.vue

yadvr · 2020-06-16T07:05:24Z

@utchoang I tested latest master, and couldn't reproduce the issue; please re-open if I missed any case or the issue still exists. Thanks.

utchoang · 2020-06-16T07:13:59Z

@rhtyd With the exception of scrolling information, I've corrected some missing points in the auto-selection section when turning pages in each section (When turning pages, the auto-select is not correct). I will remove the roll, can you check and merge it for me, please?

yadvr · 2020-06-16T07:16:09Z

@utchoang alright please merge latest master and let me know when it's ready for review/testing. Thanks.

yadvr · 2020-06-17T05:35:39Z

@blueorangutan package

blueorangutan · 2020-06-17T05:36:30Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-17T05:45:06Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/401 (JID-2023)

yadvr · 2020-06-17T05:56:33Z

@utchoang can you test against the Primate QA server (http://primate-qa.cloudstack.cloud:8080/client/pr/401/#/action/deployVirtualMachine)

On searching the page number should reset to 1 for the selection/step
We've stopped showing the cpu number/ram etc?
Affinity groups gets empty after I click the next page

Please test it thoroughly against Primate QA server and/or any local setup and ping me when you're done. Thanks.

utchoang · 2020-06-17T08:27:07Z

@rhtyd I've completed fixed it. About the issue "Affinity groups get empty after clicking the next page". I don't understand why when I called listAffinityGroups, the API responded with count > item length result (bellow image). Thanks.

yadvr · 2020-06-17T09:18:37Z

@shwstppr - can you check if this is an issue with the backend API implementation; i.e. wrong count is sent for the API response (if yes, please send a PR to apache/cloudstack targetting 4.13 branch). cc @davidjumani

yadvr · 2020-06-17T10:24:05Z

@utchoang can you fix the conflict? Thanks.

utchoang · 2020-06-18T02:40:31Z

@rhtyd I've resolved it. Thanks.

# Conflicts: # src/views/compute/DeployVM.vue

yadvr · 2020-06-18T04:27:37Z

@blueorangutan package

blueorangutan · 2020-06-18T04:28:50Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-18T04:38:38Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/401 (JID-2038)

shwstppr · 2020-06-18T08:37:57Z

@shwstppr - can you check if this is an issue with the backend API implementation; i.e. wrong count is sent for the API response (if yes, please send a PR to apache/cloudstack targetting 4.13 branch). cc @davidjumani

@utchoang apache/cloudstack#4154 should solve the wrong count issue for AG

yadvr · 2020-06-18T10:34:10Z

@blueorangutan package

blueorangutan · 2020-06-18T10:35:35Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

yadvr

LGTM will need to a final test and merge

blueorangutan · 2020-06-18T10:45:51Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/401 (JID-2051)

yadvr · 2020-06-18T10:48:24Z

@utchoang @svenvogel can you check on the above env, run a full end-to-end VM deployment wizard test ? Thanks.

Deployment wizard fails for me:

TypeError: Cannot read property 'keyboardOptions' of undefined
    at o.keyboardSelectOptions (DeployVM.vue:685)
    at nr.get (vue.runtime.esm.js:4479)
    at nr.evaluate (vue.runtime.esm.js:4584)
    at o.keyboardSelectOptions (vue.runtime.esm.js:4836)
    at o.s (DeployVM.vue?c94a:10)
    at o.e._render (vue.runtime.esm.js:3548)
    at o.r (vue.runtime.esm.js:4066)
    at nr.get (vue.runtime.esm.js:4479)
    at nr.run (vue.runtime.esm.js:4554)
    at Xn (vue.runtime.esm.js:4310)
it @ vue.runtime.esm.js:8
rt @ vue.runtime.esm.js:8
tt @ vue.runtime.esm.js:8
e._render @ vue.runtime.esm.js:8
r @ vue.runtime.esm.js:8
nr.get @ vue.runtime.esm.js:8
nr.run @ vue.runtime.esm.js:8
Xn @ vue.runtime.esm.js:8
(anonymous) @ vue.runtime.esm.js:8
lt @ vue.runtime.esm.js:8
Promise.then (async)
at @ vue.runtime.esm.js:8
pt @ vue.runtime.esm.js:8
er @ vue.runtime.esm.js:8
nr.update @ vue.runtime.esm.js:8
ve.notify @ vue.runtime.esm.js:8
set @ vue.runtime.esm.js:8
setState @ chunk-vendors.e4a86834.js:74
setOpenState @ moment.js:5621
onMenuSelect @ moment.js:5621
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ moment.js:5621
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ chunk-vendors.e4a86834.js:1
click @ chunk-vendors.e4a86834.js:1
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ index.js:1
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
Qi.a._wrapper @ vue.runtime.esm.js:8
vue.runtime.esm.js:1888 TypeError: Cannot read property 'keyboardOptions' of undefined
    at o.keyboardSelectOptions (DeployVM.vue:685)
    at nr.get (vue.runtime.esm.js:4479)
    at nr.evaluate (vue.runtime.esm.js:4584)
    at o.keyboardSelectOptions (vue.runtime.esm.js:4836)
    at o.s (DeployVM.vue?c94a:10)
    at o.e._render (vue.runtime.esm.js:3548)
    at o.r (vue.runtime.esm.js:4066)
    at nr.get (vue.runtime.esm.js:4479)
    at nr.run (vue.runtime.esm.js:4554)
    at Xn (vue.runtime.esm.js:4310)
it @ vue.runtime.esm.js:8
rt @ vue.runtime.esm.js:8
tt @ vue.runtime.esm.js:8
e._render @ vue.runtime.esm.js:8
r @ vue.runtime.esm.js:8
nr.get @ vue.runtime.esm.js:8
nr.run @ vue.runtime.esm.js:8
Xn @ vue.runtime.esm.js:8
(anonymous) @ vue.runtime.esm.js:8
lt @ vue.runtime.esm.js:8
Promise.then (async)
at @ vue.runtime.esm.js:8
pt @ vue.runtime.esm.js:8
er @ vue.runtime.esm.js:8
nr.update @ vue.runtime.esm.js:8
e.$forceUpdate @ vue.runtime.esm.js:8
(anonymous) @ chunk-207263fb.6225f06d.js:1
(anonymous) @ lodash.js:1
(anonymous) @ lodash.js:1
Ti @ lodash.js:1
(anonymous) @ lodash.js:1
ra @ lodash.js:1
pl @ lodash.js:1
(anonymous) @ chunk-207263fb.6225f06d.js:1
(anonymous) @ lodash.js:1
(anonymous) @ lodash.js:1
Ti @ lodash.js:1
(anonymous) @ lodash.js:1
ra @ lodash.js:1
pl @ lodash.js:1
(anonymous) @ chunk-207263fb.6225f06d.js:1
Promise.then (async)
fetchOptions @ chunk-207263fb.6225f06d.js:1
(anonymous) @ chunk-207263fb.6225f06d.js:1
(anonymous) @ lodash.js:1
Ti @ lodash.js:1
(anonymous) @ lodash.js:1
cl @ lodash.js:1
onSelectZoneId @ chunk-207263fb.6225f06d.js:1
Object.keys.forEach.l.<computed> @ moment.js:5621
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
nt @ vue.runtime.esm.js:8
Tn.e.$emit @ vue.runtime.esm.js:8
fireChange @ moment.js:5621
onMenuSelect @ moment.js:5621
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ moment.js:5621
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ chunk-vendors.e4a86834.js:1
click @ chunk-vendors.e4a86834.js:1
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
__emit @ chunk-vendors.e4a86834.js:74
onClick @ index.js:1
nt @ vue.runtime.esm.js:8
n @ vue.runtime.esm.js:8
Qi.a._wrapper @ vue.runtime.esm.js:8
vue.runtime.esm.js:1888 TypeError: Cannot read property 'keyboardOptions' of undefined
    at o.keyboardSelectOptions (DeployVM.vue:685)
    at nr.get (vue.runtime.esm.js:4479)
    at nr.evaluate (vue.runtime.esm.js:4584)
    at o.keyboardSelectOptions (vue.runtime.esm.js:4836)
    at o.s (DeployVM.vue?c94a:10)
    at o.e._render (vue.runtime.esm.js:3548)
    at o.r (vue.runtime.esm.js:4066)
    at nr.get (vue.runtime.esm.js:4479)

yadvr · 2020-06-18T10:49:36Z

@utchoang another issue:

When ISO is selected the user must select a disk offering (for the root disk), but no thank you is selected

yadvr · 2020-06-19T10:31:26Z

@blueorangutan package

blueorangutan · 2020-06-19T10:32:44Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-19T10:40:32Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/401 (JID-2055)

* add scroll to vm info * fix "un-choose" the Zone/Pod/Host and row selected when changing page sections * remove 'un-choose' selection in zone, cluster, pod, host * fix issue when selected page, hidden cpu/ram affinity groups * revert affinityGroup total count * fix error lint & disk offering selection

add scroll to vm info

58f9afd

utchoang marked this pull request as draft June 8, 2020 04:18

fix "un-choose" the Zone/Pod/Host and row selected when changing page…

c5b1c7c

… sections

utchoang marked this pull request as ready for review June 8, 2020 09:12

yadvr added this to the 1.0-GA milestone Jun 14, 2020

Merge branch 'master-upstream' into feature/fix-vm-instance

fa040df

# Conflicts: # src/views/compute/DeployVM.vue

yadvr closed this Jun 16, 2020

yadvr reopened this Jun 16, 2020

remove 'un-choose' selection in zone, cluster, pod, host

1af975a

fix issue when selected page, hidden cpu/ram affinity groups

d0c2f49

Merge branch 'master-upstream' into feature/fix-vm-instance

8d826a3

# Conflicts: # src/views/compute/DeployVM.vue

revert affinityGroup total count

03a1208

yadvr approved these changes Jun 18, 2020

View reviewed changes

fix error lint & disk offering selection

051c081

yadvr merged commit 5be8e4e into apache:master Jun 20, 2020

utchoang deleted the feature/fix-vm-instance branch June 22, 2020 00:28

Conversation

utchoang commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Jun 8, 2020

Uh oh!

utchoang commented Jun 8, 2020

Uh oh!

yadvr commented Jun 14, 2020

Uh oh!

yadvr commented Jun 16, 2020

Uh oh!

utchoang commented Jun 16, 2020

Uh oh!

yadvr commented Jun 16, 2020

Uh oh!

yadvr commented Jun 17, 2020

Uh oh!

blueorangutan commented Jun 17, 2020

Uh oh!

blueorangutan commented Jun 17, 2020

Uh oh!

yadvr commented Jun 17, 2020

Uh oh!

utchoang commented Jun 17, 2020

Uh oh!

yadvr commented Jun 17, 2020

Uh oh!

yadvr commented Jun 17, 2020

Uh oh!

utchoang commented Jun 18, 2020

Uh oh!

yadvr commented Jun 18, 2020

Uh oh!

blueorangutan commented Jun 18, 2020

Uh oh!

blueorangutan commented Jun 18, 2020

Uh oh!

shwstppr commented Jun 18, 2020

Uh oh!

yadvr commented Jun 18, 2020

Uh oh!

blueorangutan commented Jun 18, 2020

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 18, 2020

Uh oh!

yadvr commented Jun 18, 2020

Uh oh!

yadvr commented Jun 18, 2020

Uh oh!

yadvr commented Jun 19, 2020

Uh oh!

blueorangutan commented Jun 19, 2020

Uh oh!

blueorangutan commented Jun 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

utchoang commented Jun 8, 2020 •

edited

Loading