api,ui: fix empty source cidr value for firewall rule

[shwstppr]

Description

Fixes #10002

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-509)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (9967bb3) to head (20244ab).
Report is 34 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10208      +/-   ##
============================================
+ Coverage     15.13%   15.14%   +0.01%     
- Complexity    11274    11285      +11     
============================================
  Files          5408     5408              
  Lines        473974   473769     -205     
  Branches      57813    57813              
============================================
+ Hits          71730    71768      +38     
+ Misses       394227   393982     -245     
- Partials       8017     8019       +2     

Flag	Coverage Δ
uitests	4.30% <ø> (-0.01%)	⬇️
unittests	15.87% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10208 (QA-JID-510)

[abh1sar]

LGTM.

p.s. what would be the behaviour if the same was done using api (Passing empty string cidr)? If it is the same, can we sanitise the input or throw some error from the api?

[shwstppr]

@abh1sar API was allowing empty cidr as it takes List as input,

(qaserver) 🐱 > create firewallrule cidrlist= protocol=tcp ipaddressid=e7314c68-c570-42c5-939e-e61f5b30cb4b startport=22 endport=22
{
  "firewallrule": {
    "cidrlist": "",
    "destcidrlist": "",
    "endport": 22,
    "fordisplay": true,
    "id": "2a0c6f0f-bb4c-4f2d-9c2d-1129b523f584",
    "ipaddress": "192.168.1.173",
    "ipaddressid": "e7314c68-c570-42c5-939e-e61f5b30cb4b",
    "networkid": "00089a57-3cc1-4ddc-973c-251a6f097372",
    "protocol": "tcp",
    "startport": 22,
    "state": "Active",
    "tags": [],
    "traffictype": "Ingress"
  }
}

I've added a check

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12164

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12184

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12176)

[weizhouapache]

code lgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[LL]Trillian test result (tid-7066)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 41014 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10208-t7066-kvm-alma8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-12185)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45412 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10208-t12185-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm, tested in a lab env (also unit tests provided