Skip to content

linstor: improve integration-tests#10439

Merged
Pearl1594 merged 1 commit intoapache:4.19from
LINBIT:linstor-4.19-update-tests
Mar 3, 2025
Merged

linstor: improve integration-tests#10439
Pearl1594 merged 1 commit intoapache:4.19from
LINBIT:linstor-4.19-update-tests

Conversation

@rp-
Copy link
Contributor

@rp- rp- commented Feb 21, 2025

Description

make tests easier to run and without modifying the test to match the correct system. Also add tests for volume and vm instance snapshots. Improve runtime by ~6 minutes.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

make tests easier to run and without modifying the test to match the
correct system. Also add tests for volume and vm instance snapshots.
Improve runtime by ~6 minutes.
@rp- rp- self-assigned this Feb 21, 2025
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Feb 21, 2025
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (e196275) to head (49d972d).
Report is 9 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10439      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
+ Complexity    11314    11311       -3     
============================================
  Files          5413     5413              
  Lines        474704   474704              
  Branches      57893    57893              
============================================
- Hits          71942    71925      -17     
- Misses       394717   394737      +20     
+ Partials       8045     8042       -3     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@DaanHoogland DaanHoogland added this to the 4.19.3 milestone Feb 21, 2025
@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12534

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12484)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43502 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10439-t12484-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, maybe worth one day looking at whther those wait functions could be pulled upwards to cloudstackTestCase and be used more gnerically.

@DaanHoogland DaanHoogland requested a review from Pearl1594 March 3, 2025 15:35
@Pearl1594 Pearl1594 merged commit 217e534 into apache:4.19 Mar 3, 2025
25 checks passed
@rp- rp- deleted the linstor-4.19-update-tests branch March 11, 2025 07:29
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
make tests easier to run and without modifying the test to match the
correct system. Also add tests for volume and vm instance snapshots.
Improve runtime by ~6 minutes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants