VR: dnsmasq does not listen on 127.0.0.1

[weizhouapache]

Description

This PR fixes #10436

More info at #10436 (comment)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (e196275) to head (6532246).
Report is 38 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10440   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
  Complexity    11314    11314           
=========================================
  Files          5413     5413           
  Lines        474704   474704           
  Branches      57893    57893           
=========================================
  Hits          71942    71942           
  Misses       394717   394717           
  Partials       8045     8045           

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm, but needs testing with loads of networks.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12533

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12485)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10440-t12485-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[JoaoJandre]

@weizhouapache could you add some explanation on the cause of #10436 and how this PR fixes it?

Maybe I've missed it on the issue but I was not able to find it there. Without context, it is hard to judge if these changes are ok or not.

[weizhouapache]

@weizhouapache could you add some explanation on the cause of #10436 and how this PR fixes it?

Maybe I've missed it on the issue but I was not able to find it there. Without context, it is hard to judge if these changes are ok or not.

@JoaoJandre
Refer to my comment #10436 (comment)

ACS indeed tried to release the ip but the lease file was not changed.

You can test shared network with ACS 4.20

[weizhouapache]

I tried to reproduce the issue today, but failed

I am closing the PR. will re-visit later.

cc @DaanHoogland @vishesh92 @JoaoJandre