linstor: implement missing deleteDatastore

[rp-]

Description

Somehow deleteDatastore was never implemented, that meant: templates haven't been cleaned up on datastore delete and also agents have never been informed about storage pool removal.
Fixes: #10465

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Adding/removing Linstor primary storage.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (95c2481) to head (9496150).
Report is 5 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (95c2481) and HEAD (9496150). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (95c2481)	HEAD (9496150)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.19   #10561       +/-   ##
=============================================
- Coverage     15.16%    4.28%   -10.88%     
=============================================
  Files          5414      368     -5046     
  Lines        474804    29656   -445148     
  Branches      57909     5207    -52702     
=============================================
- Hits          72002     1272    -70730     
+ Misses       394749    28239   -366510     
+ Partials       8053      145     -7908     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[Pearl1594]

code lgtm

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12773

[rp-]

share the code now and did Daans suggestions

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Pearl1594]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12785

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12704)

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12725)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51664 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10561-t12725-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	Error	394.37	test_vm_life_cycle.py

[Pearl1594]

Merging based on test run - as there's no access to a setup to test this.