ui: fix advance setting behaviour in autoscale form#11306
ui: fix advance setting behaviour in autoscale form#11306sureshanaparti merged 1 commit intoapache:4.19from
Conversation
Fixes apache#11269 The current dysfunctional behaviour was introduced in apache#6571. In advanced settings interface for ssh keypairs, userdata, affinity group, etc are show but the toggle to show/hide them was not working correctly. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11306 +/- ##
============================================
- Coverage 15.17% 15.17% -0.01%
Complexity 11362 11362
============================================
Files 5415 5415
Lines 476030 476030
Branches 58115 58115
============================================
- Hits 72246 72243 -3
- Misses 395701 395703 +2
- Partials 8083 8084 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the autoscale form's advanced settings toggle behavior. The advanced settings interface for SSH keypairs, userdata, and affinity groups was not properly showing/hiding when the toggle was activated.
Key Changes
- Replaced
v-showdirective withv-ifdirective for the advanced settings container
|
able to reproduce with qa simulator env, and verified with pr's simulator env. |
Fixes apache#11269 The current dysfunctional behaviour was introduced in apache#6571. In advanced settings interface for ssh keypairs, userdata, affinity group, etc are show but the toggle to show/hide them was not working correctly. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
Fixes #11269
The current dysfunctional behaviour was introduced in #6571. In advanced settings interface for ssh keypairs, userdata, affinity group, etc are show but the toggle to show/hide them was not working correctly.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?