server: pass network label of physical network when plug nic for private gateway on hypervisor

[weizhouapache]

Description

This PR fixes #11798

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.18%. Comparing base (eee43e5) to head (26c0329).
⚠️ Report is 113 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../main/java/com/cloud/network/NetworkModelImpl.java	0.00%	3 Missing ⚠️
...network/dao/PhysicalNetworkTrafficTypeDaoImpl.java	0.00%	2 Missing ⚠️
...cloud/hypervisor/kvm/resource/BridgeVifDriver.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11846      +/-   ##
============================================
+ Coverage     16.17%   16.18%   +0.01%     
- Complexity    13300    13303       +3     
============================================
  Files          5656     5657       +1     
  Lines        498349   498467     +118     
  Branches      60480    60493      +13     
============================================
+ Hits          80597    80692      +95     
- Misses       408778   408795      +17     
- Partials       8974     8980       +6     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.04% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

Code looks good @weizhouapache , are you still working on this or testing this?

[abh1sar]

@weizhouapache is this ready for review or needs more work?

[weizhouapache]

@weizhouapache is this ready for review or needs more work?

it is ready for review
thanks for the headsup @abh1sar

[DaanHoogland]

clgtm

[sureshanaparti]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16618

[borisstoyanov]

LGTM, manually checked the bug fix

[weizhouapache]

LGTM, manually checked the bug fix

great, thanks @borisstoyanov