[VMware DRS] Adding new host to DRS cluster does not participate in load balancing.#1257
Conversation
There was a problem hiding this comment.
Hi @sureshanaparti could you consider making a Jira? As a suggestion, could you remove those underscore "_" before variables? That convention is not recommended in Java.
Furthermore, could make a JavaDoc? That could save some time for those that are going to read your code in the future and turns things easier and organized.
There was a problem hiding this comment.
@rodrigo93 This fix was part of the jira CLOUDSTACK-9175. Maintained the same conventions as in this class. The underscore "_" is prepended to all the member variables of the class.
|
@sureshanaparti There are some open items, please address them |
|
@sureshanaparti please rebase against latest master, thanks tag:vmware-pickup |
|
would like to see this fixed, @sureshanaparti can I help you out? |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests: Skipped tests: Passed test suits: |
sureshanaparti
force-pushed
the
CLOUDSTACK-9175
branch
2 times, most recently
from
c533665 to
01c95f9
Compare
|
Addressed all the changes suggested and rebased against latest master.
|
|
@blueorangutan test centos6 vmware-55u3 |
|
@sureshanaparti sorry, this is a restricted command to avoid resource abuse issues. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
sureshanaparti
force-pushed
the
CLOUDSTACK-9175
branch
from
01c95f9 to
11764fc
Compare
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-306 |
|
@sureshanaparti do you think this would be useful for 4.9? If so, can you change PR's base branch to 4.9 and rebase your branch against 4.9? |
There was a problem hiding this comment.
LGTM. @sureshanaparti this could be good candidate for 4.9 as well.
sureshanaparti
force-pushed
the
CLOUDSTACK-9175
branch
from
11764fc to
16d78f7
Compare
|
@rhtyd Changed base branch to 4.9 and rebased against 4.9. This would be useful for 4.9. |
|
@sureshanaparti thanks, I'll kick some tests. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-370 |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-371 |
|
@blueorangutan test centos7 vmware-55u3 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-637)
|
sureshanaparti
force-pushed
the
CLOUDSTACK-9175
branch
from
07e48f3 to
343b065
Compare
sureshanaparti
changed the title
|
@blueorangutan package |
rebased, and tested @rhtyd |
|
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 911 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1699)
|
.../hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
Outdated
Show resolved
Hide resolved
… participate in load balancing. Summary: When a new host is added to a cluster, Cloudstack doesn't create all the port groups (created by cloudstack earlier in other hosts) present in the cluster. Since the new host doesn't have all the necessary networking port groups of cloudstack, it is not eligible to participate in DRS load balancing or HA. Solution: When adding a host to the cluster in Cloudstack, use VMware API to find the list of unique port groups on a previously added host (older host in the cluster) if exists and then create them on the new host.
sureshanaparti
force-pushed
the
CLOUDSTACK-9175
branch
from
343b065 to
1a41837
Compare
|
@blueorangutan package |
|
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 998 |
|
@blueorangutan test centos7 vmware-67u3 |
|
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1764)
|
|
👏 6 year old PR gets merged |
16 participants
Description
CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
Summary: When a new host is added to a cluster, Cloudstack doesn't create all the port groups (created by cloudstack earlier in other hosts) present in the cluster. Since the new host doesn't have all the necessary networking port groups of cloudstack, it is not eligible to participate in DRS load balancing or HA.
Solution: When adding a host to the cluster in Cloudstack, use VMware API to find the list of unique port groups on a previously added host (older host in the cluster) if exists and then create them on the new host.
Fixes: #3156
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Manually tested adding a new host in the VMware cluster, and verified the port groups added in the new host.