add user-agent header to template downloader request

[sudo87]

Description

This PR adds user-agent header to download request.

Some template providers reject HTTP requests without a User-Agent
header and return HTTP 403 instead of redirecting to the actual
download location. This causes template downloads to fail.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (7aa0558) to head (c1eb8a5).
⚠️ Report is 6 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...cloud/storage/template/HttpTemplateDownloader.java	0.00%	1 Missing ⚠️
...d/storage/template/MetalinkTemplateDownloader.java	0.00%	1 Missing ⚠️
...torage/template/SimpleHttpMultiFileDownloader.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12791      +/-   ##
============================================
- Coverage     17.61%   17.60%   -0.01%     
+ Complexity    15664    15657       -7     
============================================
  Files          5917     5917              
  Lines        531402   531415      +13     
  Branches      64971    64972       +1     
============================================
- Hits          93596    93579      -17     
- Misses       427252   427281      +29     
- Partials      10554    10555       +1     

Flag	Coverage Δ
uitests	3.70% <ø> (-0.01%)	⬇️
unittests	18.68% <25.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 17096

[weizhouapache]

@sudo87
code looks ok

any linked issue ?

[sureshanaparti]

@sudo87 code looks ok

any linked issue ?

@weizhouapache it seems no linked issue for this.

[sureshanaparti]

@sudo87 check if the user-agent update is relavent in createRequest() at MetalinkTemplateDownloader, SimpleHttpMultiFileDownloader, HttpDirectTemplateDownloader.

[sureshanaparti]

clgtm

[sudo87]

@sudo87 check if the user-agent update is relavent in createRequest() at MetalinkTemplateDownloader, SimpleHttpMultiFileDownloader, HttpDirectTemplateDownloader.

Thanks @sureshanaparti for your feedback on the pr. I think there is no harm adding user-agent in the GetMethod request, updated the pr accordingly.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17116

[sudo87]

@blueorangutan test

[blueorangutan]

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15638)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50270 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12791-t15638-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.14	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	3.90	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.72	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	46.72	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	27.49	test_snapshots.py
test_01_snapshot_usage	Error	32.91	test_usage.py
test_01_vpn_usage	Error	1.12	test_usage.py

[vishesh92]

The code looks good. My only concern (not sure about the impact) is the value for the user agent. We should ensure it matches the format as per the RFC. below is the output from quick web search.
Ref:
https://www.rfc-editor.org/rfc/rfc9110.html#section-10.1.5
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent