CLOUDSTACK-10220: Configure IPv4 alias on VR regardless of IPv6

[wido]

For some reason when a IPv6 address is present for a NIC IPv4 subnet aliases are not configured on the VR.

This seems to be very old code (>5 yr) and written at a time when IPv6 wasn't implemented in CloudStack

Removing this additional evaluation in the if-statement works for us in Basic Networking

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1642

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2109)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35734 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2396-t2109-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_vm_wrong_checksum	Error	59.40	test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown	Error	73.08	test_templates.py
test_07_resize_fail	Failure	4.52	test_volumes.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	2.56	test_host_maintenance.py

[yadvr]

Tests LGTM. Failures not related to this PR.
Given @wido has flagged this as a blocker due to issue in 4.10, we can accept this PR towards 4.11 milestone as a blocker fix if others agree in the community - @DaanHoogland @rafaelweingartner @marcaurele @borisstoyanov @bwsw @resmo and others.

[rafaelweingartner]

Everything seems to be ok. I only think that you should squash commits for this one.

[yadvr]

Thanks @rafaelweingartner, I'll squas merge this now as we're two code review lgtms and test results.