CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM by nvazquez · Pull Request #2408 · apache/cloudstack

nvazquez · 2018-01-15T12:53:04Z

Several fixes addressed:

Dettach ISO fails when trying to detach a direct download ISO
Fix for metalink support on SSVM agents (this closes CLOUDSTACK-10238)
Reinstall VM from bypassed registered template (this closes CLOUDSTACK-10250)
Fix upload certificate error message even though operation was successful
Fix metalink download, checksum retry logic and metalink SSVM downloader

yadvr · 2018-01-19T08:15:06Z

@nvazquez should this be seen as a blocker? /cc @DaanHoogland and others
@blueorangutan package

blueorangutan · 2018-01-19T08:16:02Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-01-19T08:42:51Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1661

yadvr · 2018-01-19T08:48:34Z

@blueorangutan test

blueorangutan · 2018-01-19T08:49:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2018-01-19T10:11:44Z

@rhtyd I don't think it is a blocker. It is new functionality failing, but it is nice to include if it is fixed and we need another RC.

nvazquez · 2018-01-19T11:29:05Z

@rhtyd agree with @DaanHoogland, it is a fix only for new Direct Download functionality

blueorangutan · 2018-01-19T17:23:18Z

Trillian test result (tid-2172)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30851 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2172-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 62 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	`Failure`	128.28	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	137.58	test_volumes.py
test_05_rvpc_multi_tiers	`Failure`	310.07	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	332.97	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.44	test_hostha_kvm.py

borisstoyanov

LGTM, I've run the results manually and they passed

[root@trl-1183-k-cs411-bstoyanov-marvin ~]# cat /marvin//MarvinLogs/test_vpc_redundant_7KZ1HA/results.txt
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : SUCCESS ===
ok
Create a redundant VPC with multiple tiers ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 5 tests in 2713.730s

OK

nvazquez · 2018-01-25T15:33:22Z

Thanks for manual verification @borisstoyanov! @DaanHoogland could you review this one as well?

DaanHoogland

hard to read protocol check but overall good amend of the code.

DaanHoogland · 2018-01-26T10:44:53Z

plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

+     * Return data store URL from store
+     */
+    private String getDataStoreUrlFromStore(DataStoreTO store) {
+        if (!(store instanceof NfsTO) && (!(store instanceof PrimaryDataStoreTO) ||


java could really do with an unless construct here ;)

yadvr · 2018-02-10T17:26:00Z

@blueorangutan package

blueorangutan · 2018-02-10T17:26:48Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-02-10T18:38:27Z

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1700

yadvr · 2018-02-10T19:14:06Z

@blueorangutan test

blueorangutan · 2018-02-10T19:14:48Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2018-02-15T10:53:32Z

@blueorangutan package

blueorangutan · 2018-02-15T10:54:06Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-02-15T11:47:35Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1719

nvazquez · 2018-02-15T12:54:50Z

@blueorangutan test

blueorangutan · 2018-02-15T12:55:07Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2018-02-15T16:12:20Z

this closes #2411
this closes #2423
this closes #2447

touched the code myself, by now

borisstoyanov · 2018-02-16T09:14:15Z

@blueorangutan package

blueorangutan · 2018-02-28T15:55:30Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1746

borisstoyanov · 2018-03-02T06:42:02Z

@blueorangutan package

blueorangutan · 2018-03-02T06:42:14Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-03-02T07:20:04Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1748

borisstoyanov · 2018-03-02T09:11:23Z

@blueorangutan test

blueorangutan · 2018-03-02T09:12:14Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-03-02T19:30:15Z

Trillian test result (tid-2302)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35456 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2302-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	`Failure`	128.37	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	138.78	test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.82	test_hostha_kvm.py

borisstoyanov · 2018-03-03T08:39:43Z

@blueorangutan test matrix

blueorangutan · 2018-03-03T08:40:19Z

@borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-03-03T16:30:20Z

Trillian test result (tid-2307)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25210 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2307-vmware-65.zip
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2018-03-03T17:15:54Z

Trillian test result (tid-2306)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28863 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2306-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	172.89	test_privategw_acl.py

blueorangutan · 2018-03-04T09:26:19Z

Trillian test result (tid-2310)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
Total time taken: 35723 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2310-xenserver-71.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Error`	13.63	test_scale_vm.py
test_04_extract_template	`Failure`	128.40	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	149.12	test_volumes.py

blueorangutan · 2018-03-04T09:51:04Z

Trillian test result (tid-2309)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
Total time taken: 37206 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2408-t2309-xenserver-71.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Error`	18.81	test_scale_vm.py
test_04_extract_template	`Failure`	128.32	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	142.00	test_volumes.py

nvazquez · 2018-03-06T13:44:20Z

@borisstoyanov are we ok with test results?

borisstoyanov · 2018-03-06T13:52:22Z

I'm just running a smoketest against Xen7.1, to confirm these issues are there as well and we should be good @nvazquez.

yadvr

LGTM

DaanHoogland · 2018-03-15T11:31:45Z

though I only had minimum involvement I hesitate to merge myself.
Can we merge?

DaanHoogland · 2018-03-15T11:35:20Z

@borisstoyanov @rhtyd ^^?

borisstoyanov · 2018-03-15T11:42:56Z

yes @DaanHoogland, this has passed testing and it's good for merge, smoketests are showing good results and it has enough LGTMs.

yadvr · 2018-03-15T11:43:27Z

@nvazquez can you squash commits based on JIRA id or you would like to squash the entire PR by a single JIRA id?
@DaanHoogland I can merge based on regression test results, I have not tested the feature manually myself. Maybe @borisstoyanov and @nvazquez can advise?

nvazquez · 2018-03-15T14:25:24Z

@rhtyd let me squash the entire PR to single Jira ID

nvazquez · 2018-03-15T14:44:24Z

@rhtyd done

nvazquez · 2018-03-20T11:39:58Z

@borisstoyanov @rhtyd @DaanHoogland hi guys, can we merge this one?

yadvr · 2018-03-20T13:54:59Z

Merged based on tests and reviews.

…ouds' Refatoração dos _logs_ do fluxo de migração de VM no KVM Closes apache#2408 See merge request scclouds/scclouds!1219

nvazquez added this to the 4.11.1 milestone Jan 15, 2018

nvazquez changed the base branch from master to 4.11 January 15, 2018 14:17

nvazquez force-pushed the fr16dettachisofix branch from 463f7fe to c0aca22 Compare January 15, 2018 14:20

nvazquez changed the title ~~CLOUDSTACK-10231: Dettach ISO fails for direct downloaded ISO on KVM~~ CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM Jan 15, 2018

borisstoyanov approved these changes Jan 22, 2018

View reviewed changes

DaanHoogland previously approved these changes Jan 26, 2018

View reviewed changes

DaanHoogland force-pushed the fr16dettachisofix branch from d6b2304 to 68e4f0f Compare February 15, 2018 16:18

DaanHoogland changed the title ~~CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM~~ asserted fixes for direct downloads Feb 15, 2018

yadvr approved these changes Mar 15, 2018

View reviewed changes

CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM

161926c

nvazquez force-pushed the fr16dettachisofix branch from 39c3239 to 161926c Compare March 15, 2018 14:40

nvazquez changed the title ~~asserted fixes for direct downloads~~ CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM Mar 15, 2018

yadvr merged commit 6a75423 into apache:4.11 Mar 20, 2018

nvazquez deleted the fr16dettachisofix branch April 6, 2020 14:50

Conversation

nvazquez commented Jan 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Jan 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Jan 19, 2018

Uh oh!

blueorangutan commented Jan 19, 2018

Uh oh!

yadvr commented Jan 19, 2018

Uh oh!

blueorangutan commented Jan 19, 2018

Uh oh!

DaanHoogland commented Jan 19, 2018

Uh oh!

nvazquez commented Jan 19, 2018

Uh oh!

blueorangutan commented Jan 19, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jan 25, 2018

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 26, 2018

Choose a reason for hiding this comment

Uh oh!

yadvr commented Feb 10, 2018

Uh oh!

blueorangutan commented Feb 10, 2018

Uh oh!

blueorangutan commented Feb 10, 2018

Uh oh!

yadvr commented Feb 10, 2018

Uh oh!

blueorangutan commented Feb 10, 2018

Uh oh!

nvazquez commented Feb 15, 2018

Uh oh!

blueorangutan commented Feb 15, 2018

Uh oh!

blueorangutan commented Feb 15, 2018

Uh oh!

nvazquez commented Feb 15, 2018

Uh oh!

blueorangutan commented Feb 15, 2018

Uh oh!

DaanHoogland commented Feb 15, 2018

Uh oh!

borisstoyanov commented Feb 16, 2018

Uh oh!

blueorangutan commented Feb 28, 2018

Uh oh!

borisstoyanov commented Mar 2, 2018

Uh oh!

blueorangutan commented Mar 2, 2018

Uh oh!

blueorangutan commented Mar 2, 2018

Uh oh!

borisstoyanov commented Mar 2, 2018

Uh oh!

blueorangutan commented Mar 2, 2018

Uh oh!

blueorangutan commented Mar 2, 2018

Uh oh!

borisstoyanov commented Mar 3, 2018

Uh oh!

blueorangutan commented Mar 3, 2018

Uh oh!

blueorangutan commented Mar 3, 2018

Uh oh!

blueorangutan commented Mar 3, 2018

Uh oh!

blueorangutan commented Mar 4, 2018

Uh oh!

nvazquez commented Jan 15, 2018 •

edited

Loading

yadvr commented Jan 19, 2018 •

edited

Loading