Skip to content

marvin: add missing default test data#3055

Merged
yadvr merged 1 commit intoapache:4.11from
shapeblue:marvin-default-testdata-fixes
Nov 27, 2018
Merged

marvin: add missing default test data#3055
yadvr merged 1 commit intoapache:4.11from
shapeblue:marvin-default-testdata-fixes

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Nov 24, 2018

This add missing test data for one of the keys for a recently added
migration test.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This add missing test data for one of the keys for a recently added
migration test.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.3.0 milestone Nov 24, 2018
@yadvr
Copy link
Member Author

yadvr commented Nov 24, 2018

test_migration.py passes with this, on local environment. Tested this on a monkeybox env.
@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2456

@yadvr
Copy link
Member Author

yadvr commented Nov 24, 2018

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3206)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26061 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3055-t3206-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Member Author

yadvr commented Nov 27, 2018

Ping @rafaelweingartner @wido @GabrielBrascher anyone?

@yadvr yadvr merged commit a84f7df into apache:4.11 Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants