Skip to content

server: Fix exception while update domain resource count#3204

Merged
DaanHoogland merged 1 commit intoapache:4.11from
ustcweizhou:bugfix/4.11-exception-update-domain-resource-count
Apr 29, 2019
Merged

server: Fix exception while update domain resource count#3204
DaanHoogland merged 1 commit intoapache:4.11from
ustcweizhou:bugfix/4.11-exception-update-domain-resource-count

Conversation

@ustcweizhou
Copy link
Contributor

@ustcweizhou ustcweizhou commented Mar 8, 2019

While update resource count of a domain, I got the following exception which should not happen

2019-03-05 08:23:43,656 DEBUG [c.c.u.d.T.Transaction] (qtp858242339-15:ctx-13652208 ctx-56fe3704) (logid:130b0537) Rolling back the transaction: Time = 10 Name = qtp858242339-15; called by -TransactionLegacy.rollback:890-TransactionLegacy.removeUpTo:833-TransactionLegacy.close:657-TransactionContextInterceptor.invoke:36-ReflectiveMethodInvocation.proceed:174-ExposeInvocationInterceptor.invoke:92-ReflectiveMethodInvocation.proceed:185-JdkDynamicAopProxy.invoke:212-$Proxy42.countCpuNumberAllocatedToAccount:-1-ResourceLimitManagerImpl.countCpusForAccount:950-ResourceLimitManagerImpl.recalculateAccountResourceCount:910-ResourceLimitManagerImpl$3.doInTransaction:872

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

While update resource count of a domain, I got the following exception which should not happen

2019-03-05 08:23:43,656 DEBUG [c.c.u.d.T.Transaction] (qtp858242339-15:ctx-13652208 ctx-56fe3704) (logid:130b0537) Rolling back the transaction: Time = 10 Name =  qtp858242339-15; called by -TransactionLegacy.rollback:890-TransactionLegacy.removeUpTo:833-TransactionLegacy.close:657-TransactionContextInterceptor.invoke:36-ReflectiveMethodInvocation.proceed:174-ExposeInvocationInterceptor.invoke:92-ReflectiveMethodInvocation.proceed:185-JdkDynamicAopProxy.invoke:212-$Proxy42.countCpuNumberAllocatedToAccount:-1-ResourceLimitManagerImpl.countCpusForAccount:950-ResourceLimitManagerImpl.recalculateAccountResourceCount:910-ResourceLimitManagerImpl$3.doInTransaction:872
@yadvr yadvr added this to the 4.13.0.0 milestone Mar 26, 2019
@yadvr
Copy link
Member

yadvr commented Mar 26, 2019

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2646

@GabrielBrascher
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2716

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3537)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27985 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3204-t3537-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 67 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 385.38 test_vpc_vpn.py

@DaanHoogland
Copy link
Contributor

reviewed the test error, it is a failing ssh connection, nothing to do with this

@DaanHoogland DaanHoogland merged commit b60daf7 into apache:4.11 Apr 29, 2019
DaanHoogland pushed a commit that referenced this pull request Apr 29, 2019
DaanHoogland pushed a commit that referenced this pull request Apr 29, 2019
@yadvr yadvr modified the milestones: 4.13.0.0, 4.11.3.0 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants