Skip to content

ui: remove CA certificate button from UI#3211

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:ui-ca-button-remove
Mar 25, 2019
Merged

ui: remove CA certificate button from UI#3211
yadvr merged 1 commit intoapache:masterfrom
shapeblue:ui-ca-button-remove

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Mar 12, 2019

This removes CA certificate button from UI as this is not used and
confuses both admin and users how to use it. This may be re-introduced
in future when a use-case can be justified.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This removes CA certificate button from UI as this is not used and
confuses both admin and users how to use it. This may be re-introduced
in future when a use-case can be justified.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Mar 12, 2019
@svenvogel
Copy link
Contributor

@rhtyd what was the use case before?

@yadvr
Copy link
Member Author

yadvr commented Mar 12, 2019

@svenvogel in 4.11+ if you notice there is a button on right/top side that downloads the CA certificate. This is not used at all and confuses users/admins. This removes it. The original use-case was something to do with cert setup, but that never got implemented. We may put it back if we do that in future.

@PaulAngus
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2634

@PaulAngus
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3423)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24563 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3211-t3423-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@svenvogel
Copy link
Contributor

@rhtyd okay i see. no problem. sounds good.

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 9d3009f into apache:master Mar 25, 2019
pbankonier pushed a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019
This removes CA certificate button from UI as this is not used and
confuses both admin and users how to use it. This may be re-introduced
in future when a use-case can be justified.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants