ui: use executable template filter for users#3214
Merged
yadvr merged 1 commit intoapache:masterfrom Mar 29, 2019
Merged
Conversation
This uses the `executable` tempalte filter for fetching templates in reinstall VM form, otherwise not all allowable templates were being listed. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
|
@blueorangutan test |
|
@PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Member
|
@blueorangutan package |
|
@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2633 |
DaanHoogland
approved these changes
Mar 22, 2019
borisstoyanov
approved these changes
Mar 27, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, manually verified it
yadvr
changed the title
yadvr
changed the title
Contributor
|
@rhtyd can you please confirm this has been merged in master (4.13) as well ? |
Member
Author
|
Yes @borisstoyanov |
pbankonier
pushed a commit
to pbankonier/cloudstack
that referenced
this pull request
Apr 24, 2019
Problem: When reinstalling a VM, the UI only shows featured templates and not all possible list of allowed templates. Root Cause: The list of templates for reinstall used featured as filter in ‘listTemplates’ API which did not include all available options. Solution: The issue is fixed by using the executable template filter of the ‘listTemplates’ API to list all possible templates that a user is allowed to use to deploy a VM.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When reinstalling a VM, the UI only shows featured templates and not all possible list of allowed templates.
Root Cause: The list of templates for reinstall used
featuredas filter in ‘listTemplates’ API which did not include all available options.Solution: The issue is fixed by using the
executabletemplate filter of the ‘listTemplates’ API to list allpossible templates that a user is allowed to use to deploy a VM.
Types of changes