storage: post process locally uploaded multi-disk ova template#3215
storage: post process locally uploaded multi-disk ova template#3215yadvr merged 1 commit intoapache:masterfrom
Conversation
This processes and handles multi-disk ova templates, checks and creates data disk templates on image storage pool and in DB. Test cases: - Upload template and check it creates multi-disk folders on secondary storage and entries in cloud.vm_template table - Upload template and kill/shutdown management server. Then restart MS to check if template sync works - Copy template across zone of an uploaded template Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
changed the title
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2667 |
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
Tested locally, local upload of multi disk templates is possible, post upload template get properly parsed and all disks/iso are available
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3459)
|
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2773 |
| VMTemplateVO templateUpdate = _templateDao.createForUpdate(); | ||
| templateUpdate.setSize(answer.getVirtualSize()); | ||
| _templateDao.update(tmpTemplate.getId(), templateUpdate); | ||
| // For multi-disk OVA, check and create data disk templates |
There was a problem hiding this comment.
i see the same commen t in three places. Is this eligible for a refactor as overloaded method?
|
The extended VMware fields are missing from the upload form Upload Template: |
|
@PaulAngus yes, it's by current implementation. Scope creep - the PR does not address that and possibly other UX enhancements. |
|
@PaulAngus I've create a ticket for the additional UI enhancement here: #3363 |
|
@PaulAngus @shwstppr (Abhishek) has implemented the UI change here: #3367 |
|
LGTM - tested with a centos template with 1 data disk and a Windows template with 1 data disk. |
|
oops? merged with [WIP] in the name? |
yadvr
changed the title
|
Fixed @DaanHoogland - not an issue, we were waiting for Paul's LGTM. |
5 participants
Problem: When a multi-disk OVA template is uploaded, only the root disk is recognized and VMs deployed using such template only get the root disk provisioned.
Root Cause: The template processor for multi-disk OVA was not used in the template upload processor.
Solution: Added support for local multi-disk OVA template upload. After a multi-disk OVA template is
uploaded, the mechanism that worked on multi-disk OVA templates registered using URL is now also used to discovers and creates data-disk templates in
cloud.vm_templatetable and on the secondary storage.To enable SSL on SSVMs :
• Upload the certificates like you usually do via the API or UI->Infrastructure tab
• Set the global settings secstorage.encrypt.copy, secstorage.ssl.cert.domain to appropriate values
along with the CPVM ones
• Restart management server (no need to destroy/restart SSVM (or the ssvm agent))
Test cases:
storage and entries in cloud.vm_template table
to check if template sync works
Signed-off-by: Rohit Yadav rohit.yadav@shapeblue.com
Types of changes