api: include tags in listvmsnapshots response#3216
Merged
yadvr merged 1 commit intoapache:masterfrom May 10, 2019
Merged
Conversation
This ensures that tags of a VM snapshot are listed in the UI, available in the list vmsnapshots API response. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
DaanHoogland
approved these changes
Mar 20, 2019
Contributor
|
@blueorangtan package |
Member
Author
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2647 |
Member
Author
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3447)
|
yadvr
changed the title
borisstoyanov
approved these changes
Apr 1, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, tags are listed as following:
"tags": [
{
"account": "user",
"domain": "ROOT",
"domainid": "c1bf87c5-4fb7-11e9-b7a8-1e004901077b",
"key": "vm-snap-tag1",
"resourceid": "b1d32493-33fa-47cb-bcd8-a3d5f53dd499",
"resourcetype": "VMSnapshot",
"value": "vm-snap-tag1-value"
}
],
|
LGTM |
yadvr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Tags of VM snapshots are not returned as part of the listVMSnapshots API and therefore was not shown in the UI.
Root Cause: The API response creator was not setting the tags in the API response.
Solution: The issue was fixed to return tags of a VM snapshot as part of the listVMSnapshots API response and now it is possible to list/add/remove tags using the UI. The tags are also included for VMSnapshot usage records in the listUsageRecords API response when
includetags=trueparameter is passed.Types of changes