[WIP DO NOT MERGE] ui: introduce new UI config file#3217
Closed
yadvr wants to merge 2 commits intoapache:masterfrom
Closed
[WIP DO NOT MERGE] ui: introduce new UI config file#3217yadvr wants to merge 2 commits intoapache:masterfrom
yadvr wants to merge 2 commits intoapache:masterfrom
Conversation
This introduces a new UI `config.js` file using which the UI could be configured by the admin from a single config/js file. In the first commit this allows for easy configuration of list of keyboards. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
|
@blueorangtan package |
2 similar comments
Contributor
|
@blueorangtan package |
Contributor
|
@blueorangtan package |
yadvr
requested review from
PaulAngus and
rafaelweingartner
and removed request for
PaulAngus
Contributor
|
amazing how 3 people did the same typo... |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2654 |
yadvr
changed the title
borisstoyanov
approved these changes
Mar 29, 2019
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, manually verified
Merged
5 tasks
Member
Author
|
Common changes to config.js file moved in #3258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The keyboard list in the UI is not consistent across views such as in the instance wizard and in the register template form. There is also no way to custom about url/text and doc title and help URL in the UI.
Root Cause: The list is hardcoded in the UI allowing no centralised configuration.
Solution: Introduce a new
config.jsfile installed at the/usr/share/cloudstackmanagement/webapp/config.jslocation. The config.js allows configurable keyboard list, about url/text, doc title, and help URL.Types of changes