Skip to content

server: publish volume resize event for volumes#3219

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:disk-offering-change-volume-usage
Jun 21, 2019
Merged

server: publish volume resize event for volumes#3219
yadvr merged 1 commit intoapache:masterfrom
shapeblue:disk-offering-change-volume-usage

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Mar 12, 2019

Problem: The disk offering change is not reflected in cloud_usage database table.
Root Cause: The resizeVolume API does not publish the volume disk offering change event to the
cloud_usage database table.
Solution: This issue has been fixed by refactoring the resizeVolume API to publish this disk offering change for volumes that either in Allocated or Ready state.

Moves the method that published events for volumes in Ready state from
the VolumeStateListener class to the orchestrateResizeVolume method in
the VolumeApiService.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This fixes the issue that the disk offering change is not reflected in
the cloud_usage table.

Moves the method that published events for volumes in Ready state from
the VolumeStateListener class to the orchestrateResizeVolume method in
the VolumeApiService

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Mar 12, 2019
@borisstoyanov
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2638

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3449)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32016 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3219-t3449-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr changed the title server: publish volume resize event for volumes [WIP DO NOT MERGE] server: publish volume resize event for volumes Mar 29, 2019
@yadvr
Copy link
Member Author

yadvr commented May 23, 2019

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2772

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM attached test results
test_results.xlsx

@PaulAngus
Copy link
Member

LGTM - can see that disk offering has changed from 3 to 5 and that on the 20th, disk was used partially as type 3 and partially as type 5

image

@yadvr yadvr changed the title [WIP DO NOT MERGE] server: publish volume resize event for volumes server: publish volume resize event for volumes Jun 21, 2019
@yadvr yadvr merged commit 202777e into apache:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants