volume: fix volume metrics view from returning sensitive info to end user by dhlaluku · Pull Request #3222 · apache/cloudstack

dhlaluku · 2019-03-13T08:35:32Z

Description

Problem: The listVolumeMetrics API response does not honor the volume detail visibility restrictions set for normal users and returns sensitive information which should only be visible to the root admin.

Root Cause: The listVolumeMetrics API response extends the ListVolumesByAdmin API internally and this results in a full display view response that is only meant for the root admin.

Solution: This has been fixed by rectifying the API response to not show ‘physical size’, 'storage type', and ‘storage pool’ information. The UI has also been fixed to hide these columns for normal users.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

User metrics view from the UI with physical size, storage type, and storage pool details hideen

Admin Response contains the full display view/results

How Has This Been Tested?

dhlaluku · 2019-03-13T08:39:52Z

@rhtyd please add appropriate labels for this PR

@blueorangutan package

blueorangutan · 2019-03-13T08:39:59Z

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-03-13T08:59:40Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2630

DaanHoogland · 2019-03-20T17:52:53Z

@blueorangutan test

blueorangutan · 2019-03-20T17:53:31Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-03-21T00:46:44Z

Trillian test result (tid-3427)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22768 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3222-t3427-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_network_garbage_collector_nics	`Failure`	256.54	test_vpc_redundant.py

borisstoyanov

LGTM

yadvr · 2019-05-23T14:29:32Z

@blueorangutan package

blueorangutan · 2019-05-23T14:29:59Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-05-23T16:20:49Z

Packaging result: ✖centos6 ✖centos7 ✔debian. JID-2763

DaanHoogland · 2019-05-24T10:55:35Z

just in case someone needs to play with this:
@blueorangutan package

blueorangutan · 2019-05-24T10:56:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2019-05-24T10:57:46Z

@rhtyd I saw more PRs on this subject. Is this still relevant? LGTM

blueorangutan · 2019-05-24T11:17:01Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2786

yadvr · 2019-05-24T11:31:20Z

Yes this is relevant @DaanHoogland thanks.
@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-05-24T11:32:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan · 2019-05-24T17:34:16Z

Trillian test result (tid-3583)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 20089 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3222-t3583-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 48 look OK, 22 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	0.17	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	0.18	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	1.38	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestScaleVm>:setup	`Error`	0.00	test_scale_vm.py
test_01_sys_vm_start	`Failure`	0.14	test_secondary_storage.py
test_02_sys_template_ready	`Failure`	0.10	test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.22	test_service_offerings.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_01_list_sec_storage_vm	`Failure`	0.04	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.04	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.04	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.04	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.04	test_ssvm.py
test_09_destroy_ssvm	`Failure`	0.04	test_ssvm.py
test_10_destroy_cpvm	`Failure`	0.04	test_ssvm.py
test_02_create_template_with_checksum_sha1	`Error`	65.49	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.49	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.50	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.50	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	0.12	test_templates.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup	`Error`	0.00	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	0.00	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs	`Failure`	0.14	test_host_maintenance.py

shwstppr · 2019-05-29T09:51:17Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-05-29T09:52:24Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

shwstppr

Tested it. LGTM!

yadvr · 2019-05-30T07:04:19Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-05-30T07:05:29Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

…dmins * Show disk utilization metrics for all user types

anuragaw · 2019-06-04T08:14:14Z

@blueorangutan package

anuragaw · 2019-06-04T08:14:38Z

Rebased to remove merge conflicts @rhtyd , @shwstppr , @borisstoyanov

borisstoyanov · 2019-06-07T06:45:24Z

@blueorangutan package

blueorangutan · 2019-06-07T06:46:01Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-07T07:34:57Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2862

borisstoyanov

LGTM, test results attached
test_results.xlsx

borisstoyanov approved these changes Mar 22, 2019

View reviewed changes

yadvr added the status:work-in-progress label Mar 25, 2019

yadvr requested a review from PaulAngus March 25, 2019 07:55

yadvr changed the title ~~volume: fix volume metrics view from returning sensitive info to end user~~ [WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user Mar 29, 2019

yadvr added this to the 4.13.0.0 milestone May 27, 2019

shwstppr approved these changes May 30, 2019

View reviewed changes

apache deleted a comment from blueorangutan May 30, 2019

Dingane Hlaluku added 2 commits June 4, 2019 13:42

* Hide physical size, storage type and storage pool details for non-a…

0043b97

…dmins * Show disk utilization metrics for all user types

Remove unused instance variables

5dc7236

anuragaw force-pushed the volume-metrics-views branch from 622b950 to 5dc7236 Compare June 4, 2019 08:13

borisstoyanov approved these changes Jun 7, 2019

View reviewed changes

yadvr changed the title ~~[WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user~~ volume: fix volume metrics view from returning sensitive info to end user Jun 19, 2019

yadvr removed the status:work-in-progress label Jun 19, 2019

yadvr approved these changes Jun 19, 2019

View reviewed changes

yadvr merged commit 0d6cae6 into apache:master Jun 19, 2019

Conversation

dhlaluku commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

dhlaluku commented Mar 13, 2019

Uh oh!

blueorangutan commented Mar 13, 2019

Uh oh!

blueorangutan commented Mar 13, 2019

Uh oh!

DaanHoogland commented Mar 20, 2019

Uh oh!

blueorangutan commented Mar 20, 2019

Uh oh!

blueorangutan commented Mar 21, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

DaanHoogland commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

DaanHoogland commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

yadvr commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

shwstppr commented May 29, 2019

Uh oh!

blueorangutan commented May 29, 2019

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 30, 2019

Uh oh!

blueorangutan commented May 30, 2019

Uh oh!

anuragaw commented Jun 4, 2019

Uh oh!

anuragaw commented Jun 4, 2019

Uh oh!

borisstoyanov commented Jun 7, 2019

Uh oh!

blueorangutan commented Jun 7, 2019

Uh oh!

blueorangutan commented Jun 7, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dhlaluku commented Mar 13, 2019 •

edited

Loading