Skip to content

ui: add memory used column in instance metrics view#3243

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:memory-usage-fix
May 28, 2019
Merged

ui: add memory used column in instance metrics view#3243
yadvr merged 1 commit intoapache:masterfrom
shapeblue:memory-usage-fix

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Mar 28, 2019

Problem: The metrics view for instances does not show used memory.
Root Cause: Used memory was not added as a column in the metrics view for instances.
Solution: Metrics view for instances makes ‘listVirtualMachineMetrics’ API call to gather metrics. The response of this API call contains total and free memory with the instance. These have been used to compute used memory as a percentage of total memory and displayed as a new column in UI. Also fixes
a bug for VMware, due to which incorrect memory usage was returned.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This adds memory used column in the instance metrics view. Also fixes
a bug for VMware, due to which incorrect memory usage was returned.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Mar 28, 2019
@yadvr yadvr changed the title ui: add memory used column in instance metrics view [WIP DO NOT MERGE] ui: add memory used column in instance metrics view Mar 28, 2019
@borisstoyanov
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2658

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3455)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32818 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3243-t3455-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 429.66 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 460.46 test_vpc_redundant.py

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now following is available:
"memory": 512,
"memoryintfreekbs": 393216,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"memorytotal": "0.50 GB",

@yadvr yadvr requested a review from DagSonsteboSB May 10, 2019 18:14
@yadvr
Copy link
Member Author

yadvr commented May 23, 2019

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2776

@borisstoyanov
Copy link
Contributor

borisstoyanov commented May 27, 2019

Here's a screenshot of another similar instance
Screenshot 2019-05-27 at 11 45 08

@DagSonsteboSB
Copy link

LGTM

@borisstoyanov
Copy link
Contributor

@rhtyd I think we're OK for merging this

@andrijapanicsb
Copy link
Contributor

LGTM

@yadvr
Copy link
Member Author

yadvr commented May 28, 2019

Thanks all.

@yadvr yadvr merged commit 4e8f149 into apache:master May 28, 2019
@yadvr yadvr changed the title [WIP DO NOT MERGE] ui: add memory used column in instance metrics view ui: add memory used column in instance metrics view May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants