Adding listall to listLdapConfigurations

[davidjumani]

Description

Adds the listall parameter to listLdapConfigurations.
If set to true, and no domainid specified, list all LDAP configurations irrespective of the linked domain

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

(localhost) 🐱 > list ldapconfigurations listall=true 
{
  "LdapConfiguration": [
    {
      "domainid": "3eca21e9-b1f3-11ea-ba9c-50eb71576f75",
      "hostname": "primate-qa.cloudstack.cloud",
      "port": 389
    },
    {
      "domainid": "2b660440-759f-4490-99ba-cddd9cbff2af",
      "hostname": "primate-qa.cloudstack.cloud",
      "port": 389
    },
    {
      "hostname": "primate-qa.cloudstack.cloud",
      "port": 389
    }
  ],
  "count": 3
}
(localhost) 🐱 > list ldapconfigurations 
{
  "LdapConfiguration": [
    {
      "hostname": "primate-qa.cloudstack.cloud",
      "port": 389
    }
  ],
  "count": 1
}
(localhost) 🐱 > list ldapconfigurations domainid=2b660440-759f-4490-99ba-cddd9cbff2af listall=true 
{
  "LdapConfiguration": [
    {
      "domainid": "2b660440-759f-4490-99ba-cddd9cbff2af",
      "hostname": "primate-qa.cloudstack.cloud",
      "port": 389
    }
  ],
  "count": 1
}

[davidjumani]

@rhtyd Added this to allow primate to work properly
@DaanHoogland Looks good ?
@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1427

[DaanHoogland]

looks good, i'm sorry we painted ourselves in the corner like this. One thing to test though is if multiple servers are set, either globally or on a domain. will they all show.

[davidjumani]

@blueorangutan test

[blueorangutan]

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1811)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47262 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4164-t1811-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	Error	0.03	test_pvlan.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Failure	327.85	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Failure	3780.82	test_vpc_redundant.py

[davidjumani]

@DaanHoogland tested and working for multiple servers

[DaanHoogland]

@rhtyd casn you have a look as well?

[yadvr]

LGTM, did not test it

[yadvr]

@davidjumani can you change the base branch to at least 4.14 and kick tests again? We want any bugfixes and API improvements (for Primate) to at least go into 4.14 branch.

[davidjumani]

@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1441

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1828)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27968 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4164-t1828-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	176.53	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	174.72	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	237.66	test_privategw_acl.py