Allow renaming cluster, host, and storage by GabrielBrascher · Pull Request #4165 · apache/cloudstack

GabrielBrascher · 2020-06-22T20:02:04Z

Description

This PR adds implementation for changing host and storage name, additionally, it fixes a Bug on cluster updateCluster API command. This PRs also enhances the UI by allowing editing field name on Host and Storage pool. Due to the fact that there is no support to editing cluster via UI, it was not edited.

TODO: I will address Host, Cluster, and Storage Pool name edition on CloudStack Primate once the API implementation gets merged.

Details:
Prior to this PR the following API commands did not offer support for updating name:

updateHost (enhancement)
updateStoragePool (enhancement)

Additionally, updateCluster claims to support changing a cluster name (via clustername parameter); however, such operation did not work. (bug)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Via API, change host, cluster, and storage pool names.
Via UI, change host and storage pool names.

GabrielBrascher · 2020-06-22T20:05:09Z

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java

    }

-    private void updateCluster(long clusterId, String state) {
+    private void updateCluster(long clusterId, String allocationState) {


@nvazquez can you please take a look at it?

I changed API parameter handling from separate parameters on the method call to an object of UpdateClusterCmd class. Therefore, I needed to change this tiny piece of RollingMaintenanceManagerImpl.

Thanks @GabrielBrascher, looks good to me. The change needed in RollingMaintenanceManagerImpl will be just the same as you've done below

Update Host name handling to update instead of persist Allow update Storage name

wido · 2020-06-23T07:20:35Z

Looks good to me based on the code

yadvr · 2020-06-24T02:57:54Z

Renaming of cluster on VMware could cause a problem if the cluster on VCenter is not mapped; on XenServer I'm not sure if there'll be any side-effects. On KVM LGTM

nvazquez

Code looking good, @GabrielBrascher can you please add the small refactor on RollingMaintenanceManagerImpl as well?

GabrielBrascher · 2020-06-24T20:25:37Z

@nvazquez thanks for the review!

I think that I already did the necessary changes in the method updateCluster at RollingMaintenanceManagerImpl. Please let me know if I am missing something.

GabrielBrascher · 2020-06-24T20:26:12Z

@rhtyd thanks for the feedback, I will prevent cluster renaming on VMware then (maybe on Xenserver as well).

yadvr · 2020-07-04T05:45:55Z

@blueorangutan package

blueorangutan · 2020-07-04T05:47:12Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-04T07:41:36Z

Packaging result: ✔centos7 ✔debian. JID-1528

nvazquez

LGTM based on code review, haven't tested it

GabrielBrascher · 2020-07-16T19:36:24Z

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

        boolean doUpdate = false;

+        if (org.apache.commons.lang.StringUtils.isNotBlank(name)) {
+            if(cluster.getHypervisorType() == HypervisorType.VMware) {


@rhtyd considering your concerns with issues caused by renaming VMware clusters I added this line.

yadvr · 2020-07-27T09:02:06Z

@blueorangutan package

blueorangutan · 2020-07-27T09:03:29Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-27T09:43:29Z

Packaging result: ✖centos7 ✔debian. JID-1605

yadvr · 2020-07-27T09:47:33Z

@blueorangutan package

blueorangutan · 2020-07-27T09:48:13Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-27T10:21:17Z

Packaging result: ✔centos7 ✔debian. JID-1607

yadvr · 2020-07-27T10:33:18Z

@blueorangutan test

blueorangutan · 2020-07-27T10:34:18Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-07-28T05:29:14Z

Trillian test result (tid-2205)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 66215 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4165-t2205-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	2121.32	test_kubernetes_clusters.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	`Error`	0.00	test_vm_life_cycle.py

CloudStack PR: apache/cloudstack#4165

* Allow renaming cluster, host, and storage CloudStack PR: apache/cloudstack#4165 * change clustername.label to Cluster Name

* Allow renaming cluster, host, and storage CloudStack PR: #4165 * change clustername.label to Cluster Name Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

GabrielBrascher added 2 commits June 22, 2020 02:27

Update cluster name

f5d80bb

Update name of Host

813ea48

GabrielBrascher added type:bug component:api component:UI labels Jun 22, 2020

GabrielBrascher added this to the 4.15.0.0 milestone Jun 22, 2020

GabrielBrascher self-assigned this Jun 22, 2020

GabrielBrascher commented Jun 22, 2020

View reviewed changes

GabrielBrascher requested a review from nvazquez June 22, 2020 20:05

Fix UpdateClusterCmd for Rolling maintenance, MockResourceManager

bef567f

Update Host name handling to update instead of persist Allow update Storage name

GabrielBrascher force-pushed the rename-cluster-n-host branch from 38e69e5 to bef567f Compare June 22, 2020 20:07

add log message for updating cluster and storage pool name

91961eb

nvazquez reviewed Jun 24, 2020

View reviewed changes

GabrielBrascher added the type:enhancement label Jun 24, 2020

GabrielBrascher force-pushed the rename-cluster-n-host branch from cea53fb to 74e9900 Compare June 24, 2020 20:53

Prevent renaming VMware cluster as it could cause problems.

9176e29

GabrielBrascher force-pushed the rename-cluster-n-host branch from 74e9900 to 9176e29 Compare June 24, 2020 20:54

nvazquez approved these changes Jul 7, 2020

View reviewed changes

GabrielBrascher commented Jul 16, 2020

View reviewed changes

yadvr approved these changes Aug 5, 2020

View reviewed changes

yadvr merged commit 2237486 into apache:master Aug 5, 2020

GabrielBrascher added a commit to PCextreme/cloudstack-primate that referenced this pull request Aug 24, 2020

Allow renaming cluster, host, and storage

cc0bf03

CloudStack PR: apache/cloudstack#4165

GabrielBrascher added a commit to PCextreme/cloudstack-primate that referenced this pull request Aug 24, 2020

Allow renaming cluster, host, and storage

a49b6ed

CloudStack PR: apache/cloudstack#4165

GabrielBrascher mentioned this pull request Aug 24, 2020

Allow renaming cluster, host, and storage apache/cloudstack-primate#608

Merged

yadvr pushed a commit to apache/cloudstack-primate that referenced this pull request Aug 26, 2020

Allow renaming cluster, host, and storage (#608)

b4d3f56

* Allow renaming cluster, host, and storage CloudStack PR: apache/cloudstack#4165 * change clustername.label to Cluster Name

PaulAngus removed type:bug type:enhancement labels Nov 8, 2020

ACSGitBot added the type:enhancement label Nov 8, 2020

weizhouapache pushed a commit to apache/cloudstack-primate that referenced this pull request Jan 19, 2021

Allow renaming cluster, host, and storage (#608)

bf5ae6e

* Allow renaming cluster, host, and storage CloudStack PR: apache/cloudstack#4165 * change clustername.label to Cluster Name

yadvr pushed a commit that referenced this pull request Jan 20, 2021

Allow renaming cluster, host, and storage (#608)

419387a

* Allow renaming cluster, host, and storage CloudStack PR: #4165 * change clustername.label to Cluster Name Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conversation

GabrielBrascher commented Jun 22, 2020 • edited by PaulAngus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

How Has This Been Tested?

Uh oh!

GabrielBrascher Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

nvazquez Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

wido commented Jun 23, 2020

Uh oh!

yadvr commented Jun 24, 2020

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher commented Jun 24, 2020

Uh oh!

GabrielBrascher commented Jun 24, 2020

Uh oh!

yadvr commented Jul 4, 2020

Uh oh!

blueorangutan commented Jul 4, 2020

Uh oh!

blueorangutan commented Jul 4, 2020

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 27, 2020

Uh oh!

yadvr commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 27, 2020

Uh oh!

yadvr commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 27, 2020

Uh oh!

blueorangutan commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GabrielBrascher commented Jun 22, 2020 •

edited by PaulAngus

Loading

GabrielBrascher Jul 16, 2020 •

edited

Loading