Adding missing fields to API responses by davidjumani · Pull Request #4167 · apache/cloudstack

davidjumani · 2020-06-23T10:39:50Z

Description

Adding missing fields in the following APIs
osdisplayname in listVirtualMachines
vpcofferingname in listVpcs
vpcname in listPublicIpAddresses
vpcname in listPrivateGateways
vpcname in listVpnGateways
templatename, podname in listRouters
templatename, podname in listSystemVms

Fixes: #4161

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

davidjumani · 2020-06-23T12:32:59Z

@blueorangutan package

blueorangutan · 2020-06-23T12:33:57Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-23T12:58:24Z

Packaging result: ✔centos7 ✔debian. JID-1432

davidjumani · 2020-06-23T13:01:22Z

@blueorangutan test

blueorangutan · 2020-06-23T13:01:57Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-06-24T03:12:18Z

@shwstppr can you review this?

davidjumani · 2020-06-24T07:10:47Z

@blueorangutan test

blueorangutan · 2020-06-24T07:12:06Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java

shwstppr

LGTM, adding since key for new response params can be good

api/src/main/java/org/apache/cloudstack/api/response/DomainRouterResponse.java

api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java

api/src/main/java/org/apache/cloudstack/api/response/PrivateGatewayResponse.java

api/src/main/java/org/apache/cloudstack/api/response/DomainRouterResponse.java

davidjumani · 2020-06-24T14:27:19Z

@blueorangutan package

blueorangutan · 2020-06-24T14:28:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-24T14:47:53Z

Packaging result: ✔centos7 ✔debian. JID-1450

davidjumani · 2020-06-24T14:52:12Z

@blueorangutan test

blueorangutan · 2020-06-24T14:53:01Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-06-25T00:12:39Z

Trillian test result (tid-1830)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59482 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4167-t1830-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	176.11	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	173.99	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	236.34	test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
test_01_sys_vm_start	`Failure`	0.08	test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.15	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_01_list_sec_storage_vm	`Failure`	0.06	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.06	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.08	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.09	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.06	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.06	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.06	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.11	test_ssvm.py
test_09_destroy_ssvm	`Failure`	0.11	test_ssvm.py
test_10_destroy_cpvm	`Failure`	0.10	test_ssvm.py
test_02_create_template_with_checksum_sha1	`Error`	65.38	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.37	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.37	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.37	test_templates.py
test_02_deploy_vm_from_direct_download_template	`Error`	1.20	test_templates.py
test_03_deploy_vm_wrong_checksum	`Error`	1.23	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	17.61	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=Test01DeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	0.00	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	11.45	test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration	`Error`	74.17	test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration	`Error`	1.19	test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	1.73	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	`Error`	1515.15	test_hostha_kvm.py

yadvr · 2020-06-25T00:27:42Z

@blueorangutan test

blueorangutan · 2020-06-25T00:29:09Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-06-25T01:05:57Z

Trillian test result (tid-1839)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34930 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4167-t1839-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	`Failure`	222.48	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	217.03	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	954.97	test_privategw_acl.py

yadvr added this to the 4.13.2.0 milestone Jun 23, 2020

yadvr added the component:api label Jun 23, 2020

Adding missing fields to API responses

0048d1e

davidjumani force-pushed the adding-missing-fields branch from 7161591 to 0048d1e Compare June 23, 2020 11:21

davidjumani marked this pull request as ready for review June 23, 2020 12:54

yadvr approved these changes Jun 24, 2020

View reviewed changes

apache deleted a comment from blueorangutan Jun 24, 2020

yadvr reviewed Jun 24, 2020

View reviewed changes

server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java Outdated Show resolved Hide resolved

shwstppr approved these changes Jun 24, 2020

View reviewed changes

Adding since for params

4da9dfb

davidjumani force-pushed the adding-missing-fields branch from f3b7390 to 4da9dfb Compare June 24, 2020 14:26

yadvr approved these changes Jun 25, 2020

View reviewed changes

yadvr merged commit b79407c into apache:4.13 Jun 25, 2020

DaanHoogland added the type:enhancement label Oct 21, 2020

Conversation

davidjumani commented Jun 23, 2020

Description

Types of changes

Uh oh!

davidjumani commented Jun 23, 2020

Uh oh!

blueorangutan commented Jun 23, 2020

Uh oh!

blueorangutan commented Jun 23, 2020

Uh oh!

davidjumani commented Jun 23, 2020

Uh oh!

blueorangutan commented Jun 23, 2020

Uh oh!

yadvr commented Jun 24, 2020

Uh oh!

davidjumani commented Jun 24, 2020

Uh oh!

blueorangutan commented Jun 24, 2020

Uh oh!

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidjumani commented Jun 24, 2020

Uh oh!

blueorangutan commented Jun 24, 2020

Uh oh!

blueorangutan commented Jun 24, 2020

Uh oh!

davidjumani commented Jun 24, 2020

Uh oh!

blueorangutan commented Jun 24, 2020

Uh oh!

blueorangutan commented Jun 25, 2020

Uh oh!

yadvr commented Jun 25, 2020

Uh oh!

blueorangutan commented Jun 25, 2020

Uh oh!

blueorangutan commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants