kvm/ceph: Only if a port number has been specified define in the XML#4231
kvm/ceph: Only if a port number has been specified define in the XML#4231yadvr merged 1 commit intoapache:masterfrom
Conversation
Ceph used to use port 6789 (no need to specify it), but with the messenger v2 from Ceph it switched to port 3300 while 6789 still works. librados/librbd/libvirt will automatically figure out the ports to use if none is specified. Therefor there is no need for CloudStack to explicitely define the port in the XML passed to Libvirt or Qemu. Leave blank if no port number has been defined by the user.
|
@wido reminder - can you help do the next https://github.com/ceph/rados-java release? It would be great if we can do it soon/before 4.15 to support the latest ceph release. Thanks. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔debian. JID-1629 |
|
@rhtyd I actually have rados-java 0.6.0 ready. Just need to have somebody upload it to maven central. |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2252)
|
|
seems ready to merge, right @wido @rhtyd ? |
|
For me it is |
| rbdOpts += ":mon_host=" + monHost; | ||
| if (monPort != 6789) { | ||
| if (monPort > 0) { | ||
| rbdOpts += "\\\\:" + monPort; |
There was a problem hiding this comment.
this double escape seems to byte us now ;P during release of 4.15
There was a problem hiding this comment.
@wido @weizhouapache can you comment on if this is the only issue?
5 participants
Description
Ceph used to use port 6789 (no need to specify it), but with the messenger v2
from Ceph it switched to port 3300 while 6789 still works.
librados/librbd/libvirt will automatically figure out the ports to use if none is
specified.
Therefor there is no need for CloudStack to explicitely define the port in the XML
passed to Libvirt or Qemu.
Leave blank if no port number has been defined by the user.
Types of changes