Skip to content

Update SystemVM debian iso from 10.4.0 to 10.5.0#4243

Merged
yadvr merged 1 commit intoapache:masterfrom
CLDIN:fix-deb-10-iso
Aug 6, 2020
Merged

Update SystemVM debian iso from 10.4.0 to 10.5.0#4243
yadvr merged 1 commit intoapache:masterfrom
CLDIN:fix-deb-10-iso

Conversation

@GabrielBrascher
Copy link
Member

Description

Debian 10.4.0 is not available, therefore SystemVM templates will fail to build with a missing iso.

Fixed updating with the Debian 10.5.0 iso located at https://cdimage.debian.org/debian-cd/current/amd64/iso-cd/

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Executed command to build the template:

$ sudo bash build.sh systemvmtemplate

Check that the template was successfully generated with script tools/appliance/build.sh

@GabrielBrascher GabrielBrascher added this to the 4.15.0.0 milestone Aug 4, 2020
@GabrielBrascher GabrielBrascher self-assigned this Aug 4, 2020
@GabrielBrascher GabrielBrascher changed the title Update debian 10 iso to 10.5.0 Update SystemVM debian iso from 10.4.0 to 10.5.0 Aug 4, 2020
@GabrielBrascher
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@GabrielBrascher GabrielBrascher requested a review from yadvr August 5, 2020 02:38
@blueorangutan
Copy link

Packaging result: ✔centos7 ✖debian. JID-1649

@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

Needs separate systemvm build if necessary
cc @DaanHoogland

@yadvr yadvr requested a review from DaanHoogland August 5, 2020 08:27
@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

Checked this, just URL/checksum change. Full smoketests not necessary, @GabrielBrascher have you found any reason we should build a new systemvmtemplate towards 4.15 release? Or keep using the build from June: http://download.cloudstack.org/systemvm/4.15/ cc @wido @DaanHoogland

@DaanHoogland
Copy link
Contributor

@GabrielBrascher change gtm.
Do we expect debian to just remove older 10 releases when they update? This may lead to failures after we release as well. At least for anybody building their own systemVMs. What if we release and the day after they upgrade to 10.6?

@GabrielBrascher
Copy link
Member Author

@rhtyd this happened while I was building a System VM template for testing Python3 development at PR #3730.
Depending on how #3730 progress we might or might not need a new template.

@GabrielBrascher
Copy link
Member Author

@DaanHoogland I was thinking the same. Do we need to constantly update that any time that there is another Debian 10.X?

That might be interesting thinking about new developers playing around with the system VM template. However, it might require some manual effort to keep it up to date.

@DaanHoogland
Copy link
Contributor

I like the idea but it will require designing a solution and might not be worth the effort. my question is mainly do we need this update now or do we wait till we know we need it?

@GabrielBrascher
Copy link
Member Author

@DaanHoogland that is a good question. What do you think @rhtyd?

I can close this PR if you guys think it should be addressed inside a PR when the respective requires a new system VM template.

The downside is that it could catch some developer that is not used with the building template process; but on the other hand, we don't need to keep an eye looking for changes on the Debian 10.X.Y.

Alternatives that I see:

  1. Update iso just if a new template is necessary
  2. Create some fancy way to automatically update
  3. Update at any time if someone struggle with building and sees it (no automation checking from time to time the ISO)

@DaanHoogland
Copy link
Contributor

if you need it you need it and i am fine with it. lgtm in that respect. i do not like the flimsy procedure we use, but i can live with it.

@yadvr
Copy link
Member

yadvr commented Aug 6, 2020

The systemvm py scripts are patched via systemvm.iso, so we don't need a new template unless there's something in the 10.5 update. I'll merge this as it breaks build and review/compare changes against the June build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants