UI Storage Pool Tags: unable to delete last tag#4611
Merged
yadvr merged 2 commits intoapache:4.15from Jan 25, 2021
Merged
Conversation
ui/src/views/AutogenView.vue
Outdated
| } | ||
| if (input === undefined || input === null || input === '') { | ||
| if (input === undefined || input === null || (input === '' && | ||
| !['updateStoragePool', 'updateHost'].includes(action.api))) { |
Member
There was a problem hiding this comment.
@Pearl1594 we have physical networks tags also, I just checked we could not delete the tag on physical network too, can you please add that here.
utchoang
reviewed
Jan 25, 2021
harikrishna-patnala
approved these changes
Jan 25, 2021
Member
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Thanks @Pearl1594 , looks good to me now
utchoang
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix #4610 - wherein the last tag added to a host/storage pool doesn't get deleted
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity