Skip to content

ui: fix add Vmware cluster#4663

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-add-cluster-vmware
Feb 25, 2021
Merged

ui: fix add Vmware cluster#4663
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-add-cluster-vmware

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 8, 2021

Description

When adding a cluster from an existing host-datacenter UI should list and autofill host, DC name while making addCluster API call.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before fix:
Screenshot from 2021-02-08 16-48-09

After the fix, vCenter cluster successfully added

How Has This Been Tested?

UI

  1. Deploy an env with VMware DC added in CloudStack zone with adv networking

  2. Create a new cluster in vCenter
    Screenshot from 2021-02-24 16-41-22

  3. Try to add that cluster in CloudStack UI. This will return error as shown in the above screenshot. DC name and host are set to null without querying CloudStack
    vcenter-cluster

When adding a cluster from existing host-datacenter UI shoudl list and autofill host, DC name while making addCluster API call.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr added this to the 4.15.1.0 milestone Feb 8, 2021
@shwstppr shwstppr self-assigned this Feb 8, 2021
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 8, 2021

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4663 (JID-3832)

Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need someone to do a manual test @shwstppr

@yadvr yadvr requested a review from Pearl1594 February 12, 2021 07:24
@yadvr yadvr merged commit fef0e66 into apache:4.15 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants