Display public ip addresses for shared network

[ravening]

Description

If a vm belongs to shared network then display the list
of ip addresses available which can be used to assign for
secondary IP addresses.

Also display "Public IP addresses" tab for shared networks

List all public ip address in shared network

Display the list of ip address while adding secondary ip instead of user input box

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@ravening does this rely on some code changes ?

[ravening]

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

[weizhouapache]

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

[ravening]

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

@weizhouapache I can display it

(local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
  "count": 59,
  "publicipaddress": [

[weizhouapache]

@ravening does this rely on some code changes ?

@weizhouapache dont think so.. public ip address should be listed by default

@ravening but listing ips in shared network does not work, right ?

@weizhouapache I can display it

(local) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
  "count": 59,
  "publicipaddress": [

@ravening ok.
I tested with 4.15.1.0, it worked.

by the way, forvirtualnetwork should be 'false', and networkid should be passed.

[yadvr]

@ravening @weizhouapache does it make sense to change base to 4.15 to 4.15.1?

[Pearl1594]

@ravening Could you please address the conflict. Thanks.

[shwstppr]

ping @ravening

[Pearl1594]

@blueorangutan ui

[blueorangutan]

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-81)

[Pearl1594]

@ravening I believe L466-467 need to be moved outside the if block as in a case where we have one nic on an Isolated network & one on a shared network; if you first attempt adding a secondary IP for the nic on a shared network and then do the same for the nic on Isolated network, it continues to show the shared n/ws public ips

[yadvr]

ping @ravening cc @weizhouapache - any progress/update on this?

@utchoang cc @svenvogel - can you help review/test this as well?

[utchoang]

@ravening
An error occurred while navigating to the IP address, network resource page

• Public IP resource:
  
  

• Network:
  
  

[ravening]

@ravening
An error occurred while navigating to the IP address, network resource page

• Public IP resource:
  
  
• Network:
  
  

@utchoang @Pearl1594 can you guys test/review the code again?

[Pearl1594]

@blueorangutan ui

[blueorangutan]

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4676 (SL-JID-85)

[utchoang]

LGTM!

[Pearl1594]

Verified behavior. LGTM