Skip to content

UI: German translation corrections#4759

Merged
DaanHoogland merged 3 commits intoapache:4.15from
j-porsche:ger_translation_corrections
Mar 9, 2021
Merged

UI: German translation corrections#4759
DaanHoogland merged 3 commits intoapache:4.15from
j-porsche:ger_translation_corrections

Conversation

@j-porsche
Copy link
Contributor

Description

This PR adds some missing German translations and corrects some too.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@j-porsche
Copy link
Contributor Author

@utchoang
@svenvogel

@GabrielBrascher
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4759 (JID-3849)

@yadvr
Copy link
Member

yadvr commented Mar 6, 2021

@svenvogel can you review this? Thanks.

@yadvr yadvr requested review from svenvogel and utchoang March 6, 2021 09:41
@yadvr yadvr changed the base branch from master to 4.15 March 6, 2021 09:41
@yadvr yadvr changed the base branch from 4.15 to master March 6, 2021 09:42
@yadvr
Copy link
Member

yadvr commented Mar 6, 2021

@j-porsche can you change base branch of the PR and rebase your PR branch to 4.15? This way we can get it in 4.15.1.

@j-porsche j-porsche changed the base branch from master to 4.15 March 8, 2021 09:30
@j-porsche j-porsche changed the base branch from 4.15 to master March 8, 2021 10:05
@j-porsche
Copy link
Contributor Author

Yes we can do this. Will it also be a forward merge to the master branch? @rhtyd

@DaanHoogland
Copy link
Contributor

Yes we can do this. Will it also be a forward merge to the master branch? @rhtyd

yes, @j-porsche it will

@j-porsche j-porsche force-pushed the ger_translation_corrections branch from 1c6ea92 to 1eebe52 Compare March 8, 2021 13:03
@j-porsche j-porsche changed the title German translation corrections UI: German translation corrections Mar 8, 2021
@j-porsche j-porsche changed the base branch from master to 4.15 March 8, 2021 13:08
@j-porsche
Copy link
Contributor Author

Thank You, @DaanHoogland

@svenvogel
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@svenvogel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@svenvogel svenvogel added this to the 4.15.1.0 milestone Mar 8, 2021
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4759 (JID-3858)

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested!

@DaanHoogland
Copy link
Contributor

i can review but my german is limited and biased as a dutchman. can a native speaker review? @DennisKonrad @svenvogel ...?

Copy link
Contributor

@svenvogel svenvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Checked the German language. Looks and sounds better than before. Thanks @j-porsche

@DaanHoogland DaanHoogland merged commit 5d36724 into apache:4.15 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants