Skip to content

skip livemigration for centos #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Apr 10, 2021
Merged

skip livemigration for centos #4801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08b2df6
skip lifemigration for centos
Feb 25, 2021
54a4c4a
Update test_vm_life_cycle.py
DaanHoogland Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/integration/smoke/test_vm_life_cycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,11 @@ def setUp(self):
if len(self.hosts) < 2:
self.skipTest("Requires at least two hosts for performing migration related tests")


for host in self.hosts:
Copy link
Member

@weizhouapache weizhouapache Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland it seems not be a CentOS issue, but issue with test scripts or libvrt/kvm plugin.
let's skip the live migration with volume on kvm at first, so trillian test for other prs is good.

we can fix the issue afterwards. it needs investigation.

could you change the lines to skip the test by checking the host hypervisor instead of host os ?

Copy link
Contributor Author

@DaanHoogland DaanHoogland Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could, but since the tests are for KVM only anyway, that would effectively mean disabling the tests completely.

if host.details['Host.OS'] in ['CentOS']:
self.skipTest("live migration is not stabily supported on CentOS")

def tearDown(self):
try:
cleanup_resources(self.apiclient, self.cleanup)
Expand Down