UI - Zone wizard - Fixes wrong add resource step with localstorageenabled

[utchoang]

Description

Fixes #5302

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[utchoang]

@blueorangutan ui

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5303 (SL-JID-504)

[davidjumani]

@utchoang Some of the steps are the same such as adding hosts / secondary storage. Perhaps there can just be a check on adding primary storage if localstorageenabled and changing the step numbers accordingly
On another note, should the primary storage step be removed or just skippable ? @rhtyd @shwstppr

[utchoang]

@davidjumani You can refer to https://github.com/apache/cloudstack/blob/4.14/ui/scripts/zoneWizard.js#L4454, In case both localstorageenabled && localstorageenabledforsystemvm are enabled, the step of adding primary storage will be skipped.

[davidjumani]

@utchoang That's right, my point is to skip just that step in an if condition rather than adding the redundant code of adding hosts and secondary storage in the if as well as else clause

[utchoang]

@blueorangutan ui

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[utchoang]

@davidjumani can you please check again?

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5303 (SL-JID-529)

[davidjumani]

Verified working! Thanks @utchoang