Fix iptable rules in ubuntu 20 for bridge name

[ravening]

Description

In ubuntu20 the interface name contains @ synbol and
because of that even the iptable rules for brdige name
contains this symbol which causes ping issues.
Remove the @ symbol from iptable rule to fix the issue

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

This the output from ubuntu16

# bridge -o link show | awk '/master breth0-2999 / && !/^[0-9]+: vnet/ {print $2}'
eth0.2999

And iptable rule is

-A BF-breth0-2999 -m physdev --physdev-out eth0.2999 --physdev-is-bridged -j ACCEPT

This is the output from ubuntu20

# bridge -o link show | awk '/master brens3-2999 / && !/^[0-9]+: vnet/ {print $2}'
ens3.2999@ens3

And iptable rule is

-A BF-brens3-2999 -m physdev --physdev-out ens3.2999@ens3 --physdev-is-bridged -j ACCEPT

After the fix, below is the output from ubuntu20

# bridge -o link show | awk '/master brens3-1989 / && !/^[0-9]+: vnet/ {print $2}'
ens3.1989@ens3

iptable rule is

-A BF-brens3-1989 -m physdev --physdev-out ens3.1989 --physdev-is-bridged -j ACCEPT

How Has This Been Tested?

[yadvr]

LGTM did not test it. @ravening should we migrate to using ip link (for ex. ip link show type bridge...)

[ravening]

LGTM did not test it. @ravening should we migrate to using ip link (for ex. ip link show type bridge...)

@rhtyd I thought its better to add extra flags rather than changing the command itself. Im not sure if it will break something else

[yadvr]

@ravening I tested your changes manually LGTM on Ubuntu 20.04/kvm host
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[weizhouapache]

commands looks good. need to test the iptables rules.
@ravening have you tested if the security groups are correctly applied on host and effective on vms ?

[ravening]

commands looks good. need to test the iptables rules.
@ravening have you tested if the security groups are correctly applied on host and effective on vms ?

@weizhouapache yes.. this was the only one which was causing issue in ubuntu20. apart from that all other rules worked fine so far... if I find out more then I will either update this pr or create a new one

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 882

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1657)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35433 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5318-t1657-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

code lgtm

ps: this change has been merged into master in pr#5158
2d3f2fb