Skip to content

ui: Update placeholders for adding new tier#5326

Merged
nvazquez merged 3 commits intoapache:4.15from
shapeblue:fix-tiers
Aug 19, 2021
Merged

ui: Update placeholders for adding new tier#5326
nvazquez merged 3 commits intoapache:4.15from
shapeblue:fix-tiers

Conversation

@davidjumani
Copy link
Contributor

Description

Fixes #5293

Adds a more understandable description for adding new network tiers

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Screenshot from 2021-08-17 13-24-53

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani davidjumani added this to the 4.16.0.0 milestone Aug 17, 2021
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5326 (SL-JID-530)

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5326 (SL-JID-531)

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's works. Thanks @davidjumani
image

@nvazquez
Copy link
Contributor

nvazquez commented Aug 18, 2021

@davidjumani can you target this PR to branch 4.15?

@davidjumani davidjumani changed the base branch from main to 4.15 August 18, 2021 03:46
@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5326 (SL-JID-534)

@yadvr
Copy link
Member

yadvr commented Aug 19, 2021

@davidjumani minor nit - we probably don't want the colon : after parameter names, see other forms

@utchoang
Copy link

@davidjumani
In darkmode view, please remove style="color: rgba(0,0,0,.45)" in info icon.
image

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5326 (SL-JID-537)

@nvazquez nvazquez modified the milestones: 4.16.0.0, 4.15.2.0 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VPC Add network help information as separate icon

6 participants