Skip to content

Add empty config value for scope based config setting#5551

Merged
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:empty-config-value-with-scope
Oct 5, 2021
Merged

Add empty config value for scope based config setting#5551
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:empty-config-value-with-scope

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR add empty config value for scope based config setting.

Fixes: #5545

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested empty config values in 'Domain' scope.

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1512

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

Trillian test result (tid-2320)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34390 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5551-t2320-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing using both UI and cloudmonkey.

@nvazquez nvazquez merged commit e4beb1f into apache:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot save empty value in domain settings tab

5 participants