[UI] Addressing Dynamically Scale of KVM VMs#5923
Merged
nvazquez merged 12 commits intoapache:mainfrom Feb 11, 2022
Merged
Conversation
Contributor
|
Hi @BryanMLima Is this PR good to go in 4.16.1? If so, please rebase with 4.16. Thanks. |
Contributor
Author
|
Hi @sureshanaparti, there's no need, I'm happy going to main. |
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
GutoVeronezi
approved these changes
Feb 7, 2022
Contributor
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
nvazquez
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the UI component of dynamically scale of KVM VMs partially implemented in the PR. The component Scale VM was showing all compute offering, which would lead the users to trial and error processes. Therefore, we changed it to display only the current compute offer for KVM VMs when the VM is running. If the VM is running and has a fixed offering, then it is displayed an error message. Furthermore, when a compute offering has a CPU Speed field, it defaults to the current speed of the VM offer, as oppose to zero, which is the current default behavior.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab with VMs using KVM.
VM1:
Fixed offering
VM2:
Custom offering
While VM1 was running, the scale displayed the error message. When it was in the stopped state, the scale showed all available compute offerings.
While VM2 was running, the scale only showed the current compute offering, and it shows the current CPU Speed. When it was in the stopped state, the scale showed all available offerings.