Skip to content

registry of message busses#7990

Closed
DaanHoogland wants to merge 1 commit intomainfrom
6778-if-kafka-is-turned-on-internal-subs-dont-work
Closed

registry of message busses#7990
DaanHoogland wants to merge 1 commit intomainfrom
6778-if-kafka-is-turned-on-internal-subs-dont-work

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR is a PoC for allowing multiple message busses.

Fixes: #6778

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (5c7e4b7) 29.16% compared to head (e596b10) 29.21%.
Report is 152 commits behind head on main.

Files Patch % Lines
...udstack/framework/events/EventDistributorImpl.java 40.00% 8 Missing and 4 partials ⚠️
...org/apache/cloudstack/mom/kafka/KafkaEventBus.java 0.00% 8 Missing ⚠️
...ache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 0.00% 6 Missing ⚠️
...dstack/network/contrail/management/EventUtils.java 44.44% 5 Missing ⚠️
...ache/cloudstack/mom/inmemory/InMemoryEventBus.java 42.85% 1 Missing and 3 partials ⚠️
server/src/main/java/com/cloud/api/ApiServer.java 72.72% 2 Missing and 1 partial ⚠️
...n/java/com/cloud/network/NetworkStateListener.java 90.47% 1 Missing and 1 partial ⚠️
...va/com/cloud/utils/component/ComponentContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7990      +/-   ##
============================================
+ Coverage     29.16%   29.21%   +0.05%     
- Complexity    31064    31121      +57     
============================================
  Files          5193     5194       +1     
  Lines        366292   366315      +23     
  Branches      53555    53568      +13     
============================================
+ Hits         106816   107026     +210     
+ Misses       244832   244606     -226     
- Partials      14644    14683      +39     
Flag Coverage Δ
simulator-marvin-tests 25.18% <59.63%> (+0.06%) ⬆️
uitests 4.49% <ø> (ø)
unit-tests 14.81% <3.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland reopened this Sep 21, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 25, 2023
@apache apache deleted a comment from blueorangutan Sep 26, 2023
@DaanHoogland DaanHoogland force-pushed the 6778-if-kafka-is-turned-on-internal-subs-dont-work branch from a265f48 to ebc78e3 Compare September 26, 2023 14:12
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

19.0% 19.0% Coverage
2.6% 2.6% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@DaanHoogland DaanHoogland reopened this Sep 27, 2023
@DaanHoogland DaanHoogland added this to the unplanned milestone Sep 29, 2023
@DaanHoogland DaanHoogland force-pushed the 6778-if-kafka-is-turned-on-internal-subs-dont-work branch from ebc78e3 to be01643 Compare November 20, 2023 09:07
@apache apache deleted a comment from blueorangutan Nov 20, 2023
@apache apache deleted a comment from blueorangutan Nov 20, 2023
@apache apache deleted a comment from blueorangutan Nov 20, 2023
@apache apache deleted a comment from blueorangutan Nov 20, 2023
@DaanHoogland DaanHoogland force-pushed the 6778-if-kafka-is-turned-on-internal-subs-dont-work branch 3 times, most recently from 002d8b0 to 5c73294 Compare November 20, 2023 13:53
@DaanHoogland DaanHoogland reopened this Nov 20, 2023
@DaanHoogland DaanHoogland force-pushed the 6778-if-kafka-is-turned-on-internal-subs-dont-work branch from 5c73294 to e596b10 Compare November 21, 2023 07:44
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Nov 21, 2023
@apache apache deleted a comment from blueorangutan Nov 21, 2023
@apache apache deleted a comment from blueorangutan Nov 21, 2023
@apache apache deleted a comment from blueorangutan Nov 21, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

8.2% 8.2% Coverage
2.9% 2.9% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7811

@github-actions
Copy link

github-actions bot commented Feb 8, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@shwstppr
Copy link
Contributor

@DaanHoogland Based on our discussion a week or two back, I'm closing this in favour of #8674

I've incorporated changes from here and publish on multiple event buses is working there

@shwstppr shwstppr closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If Kafka is turned on internal subs dont work

3 participants