vm-import: fix diskoffering checks for root disk

[shwstppr]

Description

Use disk offering linked with the service offering while checking for root disk during import

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@shwstppr , this is needed because of the de-coupling of service offering and disk offerings?
can you add soem test spec?
code lgtm

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 13.07%. Comparing base (3b11663) to head (1abc121).
Report is 887 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	28.57%	1 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19    #8170   +/-   ##
=========================================
  Coverage     13.06%   13.07%           
- Complexity     9111     9114    +3     
=========================================
  Files          2720     2720           
  Lines        257592   257591    -1     
  Branches      40158    40157    -1     
=========================================
+ Hits          33663    33676   +13     
+ Misses       219698   219681   -17     
- Partials       4231     4234    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@shwstppr , this is needed because of the de-coupling of service offering and disk offerings? can you add soem test spec? code lgtm

@DaanHoogland yes, it could be decoupling or maybe this has been ignored since the addition of VM import.
I've not tested this yet. Will add more details soon

[DaanHoogland]

@shwstppr is this still relevant/needed?

[yadvr]

@shwstppr is this still relevant/needed?

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.