CKS: fix creation on shared network if HA is enabled#8588
Merged
JoaoJandre merged 1 commit intoapache:4.18from Sep 26, 2024
Merged
CKS: fix creation on shared network if HA is enabled#8588JoaoJandre merged 1 commit intoapache:4.18from
JoaoJandre merged 1 commit intoapache:4.18from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8588 +/- ##
============================================
- Coverage 13.16% 13.16% -0.01%
+ Complexity 9203 9201 -2
============================================
Files 2724 2724
Lines 258087 258087
Branches 40223 40223
============================================
- Hits 33987 33984 -3
- Misses 219793 219797 +4
+ Partials 4307 4306 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
@weizhouapache is this still valid? |
Member
Author
@DaanHoogland |
Member
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11178 |
kiranchavala
approved these changes
Sep 24, 2024
Member
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
@weizhouapache , i am getting the following exception when I provide a external loadbalancer IP during cks cluster creation in a shared network
Member
Author
because 10.0.0.96.6 is not valid address |
Member
My bad should check my eye sight :-) |
Member
Author
|
@kiranchavala it does not work in advanced zone with security groups. |
kiranchavala
approved these changes
Sep 25, 2024
Member
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
Tested using nginx configuration as Loadbalancer
Able to deploy a cks cluster on a shared network with HA option enabled
sample nginx config
[root@centos7 ~]# cat nginx.conf
error_log stderr notice;
worker_processes auto;
events {
multi_accept on;
use epoll;
worker_connections 1024;
}
stream {
upstream cloudstack {
server 10.1.17.89:6443;
server 10.1.17.90:6443 backup;
server 10.1.17.86:6443 backup;
}
server {
listen 0.0.0.0:6443;
proxy_pass cloudstack;
proxy_timeout 10m;
proxy_connect_timeout 1s;
}
upstream control-1 {
server 10.1.17.89:22;
}
server {
listen 0.0.0.0:2222;
proxy_pass control-1;
proxy_timeout 10m;
proxy_connect_timeout 1s;
}
upstream control-2 {
server 10.1.17.90:22;
}
server {
listen 0.0.0.0:2223;
proxy_pass control-2;
proxy_timeout 10m;
proxy_connect_timeout 1s;
}
upstream control-3 {
server 10.1.17.86:22;
}
server {
listen 0.0.0.0:2224;
proxy_pass control-3;
proxy_timeout 10m;
proxy_connect_timeout 1s;
}
}
if there is no external IP is given exception is thrown
Member
Author
|
great, thanks for the testing @kiranchavala |
Contributor
|
@blueorangutan package |
|
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11202 |
Contributor
|
@blueorangutan test securityGroups |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Contributor
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11549)
|
Contributor
|
Merging based on reviews, manual testing (#8588 (review)) and CI results, the failures shown in CI are not related to this PR |
JoaoJandre
added a commit
that referenced
this pull request
Sep 26, 2024
* 4.18: CKS: fix creation on shared network if HA is enabled (#8588)
|
[SF] Trillian test result (tid-11548)
|
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Oct 14, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Oct 14, 2024
* 4.18: CKS: fix creation on shared network if HA is enabled (apache#8588)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #8585
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?