UI: hide Cleanup/Expunge when delete a CloudManaged CKS cluster

[weizhouapache]

Description

This PR hides the destroy/expunge option for CloudManaged CKS cluster

prior to this change

with this change

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c795547) 20.99% compared to head (7d1a0e5) 29.91%.
Report is 1 commits behind head on 4.19.

Files	Patch %	Lines
ui/src/config/section/compute.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8593      +/-   ##
============================================
+ Coverage     20.99%   29.91%   +8.91%     
- Complexity    19683    32745   +13062     
============================================
  Files          4849     5346     +497     
  Lines        324441   375423   +50982     
  Branches      45573    54598    +9025     
============================================
+ Hits          68121   112311   +44190     
- Misses       246563   248261    +1698     
- Partials       9757    14851    +5094     

Flag	Coverage Δ
simulator-marvin-tests	23.46% <ø> (+2.46%)	⬆️
uitests	4.39% <0.00%> (?)
unit-tests	16.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

Code looks good @weizhouapache , but what is the reason?
And if we want this don't we want to prevent it on the API?

[weizhouapache]

Code looks good @weizhouapache , but what is the reason?
And if we want this don't we want to prevent it on the API?

@DaanHoogland
Destroy/expunge are only applicable on ExternalManaged clusters, not CloudManaged clusters (traditional cks clusters)

Related to #7515 cc @vishesh92

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8526

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8531

[vishesh92]

clgtm.

@weizhouapache There is an additional commit from #8482. Can you please remove that?

[weizhouapache]

clgtm.

@weizhouapache There is an additional commit from #8482. Can you please remove that?

thanks for review @vishesh92
it does not matter actually, as 4.18/4.19 already has the commit.

[weizhouapache]

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[weizhouapache]

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8593 (QA-JID-319)

[vishesh92]

clgtm

[weizhouapache]

Merging
thanks @DaanHoogland @vishesh92 for review