Skip to content

engine-schema: upgrade path 4.19.0.0 to 4.20.0.0#8608

Merged
yadvr merged 1 commit intoapache:mainfrom
shapeblue:420-upgrade-path
Feb 5, 2024
Merged

engine-schema: upgrade path 4.19.0.0 to 4.20.0.0#8608
yadvr merged 1 commit intoapache:mainfrom
shapeblue:420-upgrade-path

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 5, 2024

Description

Adds an empty 4.19.0.0 to 4.20.0.0 upgrade path

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5559668) 14.39% compared to head (2b0fc3f) 4.38%.
Report is 391 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #8608       +/-   ##
============================================
- Coverage     14.39%   4.38%   -10.01%     
============================================
  Files          2747     361     -2386     
  Lines        258936   28699   -230237     
  Branches      40322    5004    -35318     
============================================
- Hits          37263    1258    -36005     
+ Misses       216860   27302   -189558     
+ Partials       4813     139     -4674     
Flag Coverage Δ
uitests 4.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Member

@shwstppr
there are build errors

Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:21:8: Unused import - java.sql.PreparedStatement. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:22:8: Unused import - java.sql.ResultSet. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:23:8: Unused import - java.sql.SQLException. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:24:8: Unused import - java.text.ParseException. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:25:8: Unused import - java.text.SimpleDateFormat. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:26:8: Unused import - java.util.Date. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:27:8: Unused import - java.util.HashMap. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:28:8: Unused import - java.util.Map. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:31:8: Unused import - org.jasypt.exceptions.EncryptionOperationNotPossibleException. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:34:8: Unused import - com.cloud.utils.DateUtil. [UnusedImports]
Error:  /home/runner/work/cloudstack/cloudstack/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41900to42000.java:35:8: Unused import - com.cloud.utils.crypt.DBEncryptionUtil. [UnusedImports]

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 5, 2024

@weizhouapache thanks for pointing that. Fixed

@yadvr yadvr added this to the 4.20.0.0 milestone Feb 5, 2024
@yadvr yadvr merged commit d353fcc into apache:main Feb 5, 2024
@yadvr yadvr deleted the 420-upgrade-path branch February 5, 2024 07:50
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants