UI: Add Migrating state in volume filtering#8631
Merged
yadvr merged 1 commit intoapache:4.19from Feb 13, 2024
Merged
Conversation
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8631 +/- ##
============================================
- Coverage 30.80% 30.70% -0.10%
+ Complexity 33981 32995 -986
============================================
Files 5341 5352 +11
Lines 374864 374414 -450
Branches 54518 54609 +91
============================================
- Hits 115485 114982 -503
- Misses 244114 244176 +62
+ Partials 15265 15256 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Feb 12, 2024
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
hard to test in QA but filtering for "Migrating" does not show all the "Ready" volumes \o/
yadvr
approved these changes
Feb 13, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Henrique Sato <henrique.sato@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GUI allows filtering volumes in several states; however, the
Migratingstate is not presented. For this reason, this PR adds theMigratingstate to the volume filtering.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I called the
migrateVolumeAPI, accessed the volumes tab in the UI and using theMigratingstate filter all volumes in theMigratingstate were returned.