Skip to content

Fixup#8636

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:fixup
Feb 9, 2024
Merged

Fixup#8636
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:fixup

Conversation

@vishesh92
Copy link
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 marked this pull request as ready for review February 9, 2024 10:44
@codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cfb4d43) 4.38% compared to head (3d3051c) 14.05%.

Files Patch % Lines
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #8636       +/-   ##
============================================
+ Coverage     4.38%   14.05%    +9.67%     
- Complexity       0    12604    +12604     
============================================
  Files          361     5216     +4855     
  Lines        28706   352145   +323439     
  Branches      5004    50578    +45574     
============================================
+ Hits          1258    49491    +48233     
- Misses       27309   295979   +268670     
- Partials       139     6675     +6536     
Flag Coverage Δ
simulator-marvin-tests 14.91% <0.00%> (?)
uitests 4.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. looks like caused by some forwarding merging.

@DaanHoogland DaanHoogland merged commit 9b18243 into apache:main Feb 9, 2024
@DaanHoogland DaanHoogland deleted the fixup branch February 9, 2024 11:19
@yadvr yadvr added this to the 4.20.0.0 milestone Feb 9, 2024
@yadvr
Copy link
Member

yadvr commented Feb 9, 2024

thanks fixing this @vishesh92

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants