Skip to content

fix: clean magic value, and update if-else to switch #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 4 commits into from
Jan 28, 2026
+20 −14
Merged

fix: clean magic value, and update if-else to switch #8848

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8000d5
fix: clean magic value, and update if-else to switch
Mar 29, 2024
78fac07
fix: return the (String args[])
Mar 29, 2024
82362a0
Merge branch '4.22' into fix/service_client
sureshanaparti Jan 27, 2026
d29fda7
review
sureshanaparti Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions services/console-proxy/rdpconsole/src/main/java/common/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ enum Protocol {
NONE, VNC, RDP, HYPERV
}

private static final String VNC = "vnc";
private static final String RDP = "rdp";
private static final String HYPERV = "hyperv";
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think, no need of this string definitions, try with string to enum constant conversion?


// Common options
private final Option help = new Option() {
{
Expand Down Expand Up @@ -299,21 +303,25 @@ private Element setMainElementAndAddressBasedOnProtocol(Protocol protocol, SSLSt

private Protocol parseOptions(String[] args) {
String protocolName = (args.length > 0) ? args[0] : "";
Protocol protocol = Protocol.NONE;
Protocol protocol;
Comment thread
DaanHoogland marked this conversation as resolved.
Comment thread
sureshanaparti marked this conversation as resolved.

Option[] options;
if (protocolName.equals("vnc")) {
protocol = Protocol.VNC;
options = join(commonOptions, vncOptions);
} else if (protocolName.equals("rdp")) {
protocol = Protocol.RDP;
options = join(commonOptions, rdpOptions);
} else if (protocolName.equals("hyperv")) {
protocol = Protocol.HYPERV;
options = join(commonOptions, hyperVOptions);
} else {
help();
return Protocol.NONE;
switch (protocolName) {
case VNC:
protocol = Protocol.VNC;
options = join(commonOptions, vncOptions);
break;
case RDP:
protocol = Protocol.RDP;
options = join(commonOptions, rdpOptions);
break;
case HYPERV:
protocol = Protocol.HYPERV;
options = join(commonOptions, hyperVOptions);
break;
default:
help();
return Protocol.NONE;
}
Comment thread
sureshanaparti marked this conversation as resolved.
Outdated

// Parse all options for given protocol
Expand Down
Loading