Fix root disk resize issue when service offering has no root disk size specified

[sureshanaparti]

Description

This PR fixes root disk resize issue when service offering has no root disk size specified.

Issue: During root disk resize, the root disk size details are checked in a different service offering (lookup with disk offering id of the root disk in service offering view).

This addresses #9380

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested the root resize with service offering having root disk size set.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.07%. Comparing base (54c8b71) to head (413edfe).
Report is 45 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9428      +/-   ##
============================================
- Coverage     15.07%   15.07%   -0.01%     
- Complexity    11169    11170       +1     
============================================
  Files          5405     5405              
  Lines        472677   472676       -1     
  Branches      60049    58516    -1533     
============================================
- Hits          71269    71268       -1     
  Misses       393479   393479              
  Partials       7929     7929              

Flag	Coverage Δ
uitests	4.27% <ø> (ø)
unittests	15.79% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10437

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10440

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-10943)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50252 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9428-t10943-kvm-centos7.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[harikrishna-patnala]

code LGTM. infact assumption of finding service offering with disk offering id is not valid now as we have decoupled service and disk offerings.

[shwstppr]

code lgtm

[vishesh92]

lgtm

[yadvr]

@vishesh92 can you confirm if you'd finished manual QA on this? thanks.

[vishesh92]

@vishesh92 can you confirm if you'd finished manual QA on this? thanks.

I had an offline discussion with @sureshanaparti and there was some confusion about the expected behaviour.

As of now, if disk size is set in the offering and disk offering's size strictness is disabled, I am not able to resize the disk.

[vishesh92]

Had another discussion with @sureshanaparti . This is working as expected. Merging.