Skip to content

Fixup CKS UI for external managed clusters#9434

Merged
yadvr merged 1 commit intoapache:4.19from
shapeblue:fixup-cks
Jul 29, 2024
Merged

Fixup CKS UI for external managed clusters#9434
yadvr merged 1 commit intoapache:4.19from
shapeblue:fixup-cks

Conversation

@vishesh92
Copy link
Member

Description

This PR fixes #9291 #9293

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.07%. Comparing base (54c8b71) to head (fcf9bf4).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9434      +/-   ##
============================================
- Coverage     15.07%   15.07%   -0.01%     
  Complexity    11169    11169              
============================================
  Files          5405     5405              
  Lines        472677   472676       -1     
  Branches      60049    59053     -996     
============================================
- Hits          71269    71265       -4     
- Misses       393479   393484       +5     
+ Partials       7929     7927       -2     
Flag Coverage Δ
uitests 4.27% <ø> (ø)
unittests 15.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10445

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan test alma9 kvm-alma9 keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10949)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 48065 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9434-t10949-kvm-alma9.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr added this to the 4.19.2.0 milestone Jul 29, 2024
@yadvr yadvr merged commit 0be87ac into apache:4.19 Jul 29, 2024
@yadvr yadvr deleted the fixup-cks branch July 29, 2024 05:19
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Remove the delete action item for cks nodes UI: Issues related to Externally managed kuberntes cluster

4 participants