Skip to content

Fix removal of usage records#9442

Merged
borisstoyanov merged 1 commit intoapache:4.18from
shapeblue:fixup-remove-usage-records
Jul 26, 2024
Merged

Fix removal of usage records#9442
borisstoyanov merged 1 commit intoapache:4.18from
shapeblue:fixup-remove-usage-records

Conversation

@vishesh92
Copy link
Member

Description

This PR fixes removal of usage records

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 force-pushed the fixup-remove-usage-records branch from 320164d to ca3c245 Compare July 25, 2024 07:49
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.26%. Comparing base (e41add3) to head (ca3c245).

Additional details and impacted files
@@            Coverage Diff             @@
##               4.18    #9442    +/-   ##
==========================================
  Coverage     12.25%   12.26%            
- Complexity     9319     9323     +4     
==========================================
  Files          4699     4699            
  Lines        414620   414617     -3     
  Branches      53404    52826   -578     
==========================================
+ Hits          50829    50845    +16     
+ Misses       357481   357457    -24     
- Partials       6310     6315     +5     
Flag Coverage Δ
unittests 12.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10470

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-10964)

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10965)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46856 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9442-t10965-kvm-centos7.zip
Smoke tests completed. 107 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_migrate_vm Error 43.79 test_vm_life_cycle.py
test_02_redundant_VPC_default_routes Failure 369.32 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 511.39 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 511.41 test_vpc_redundant.py
test_hostha_kvm_host_fencing Error 179.05 test_hostha_kvm.py

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borisstoyanov borisstoyanov merged commit 33be0ae into apache:4.18 Jul 26, 2024
@yadvr yadvr deleted the fixup-remove-usage-records branch July 29, 2024 04:08
@yadvr yadvr added this to the 4.19.2.0 milestone Jul 29, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants