Skip to content

Prevent infinite retries of autoscaling #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pearl1594 wants to merge 1 commit into from
Closed

Prevent infinite retries of autoscaling #9574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public int countAvailableVmsByGroup(long vmGroupId) {
SearchCriteria<Integer> sc = CountBy.create();
sc.setParameters("vmGroupId", vmGroupId);
sc.setJoinParameters("vmSearch", "states",
State.Starting, State.Running, State.Stopping, State.Migrating);
State.Starting, State.Running, State.Stopping, State.Migrating, State.Error, State.Stopped);
Copy link
Contributor

@shwstppr shwstppr Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may make autoscaler to not retry deployment if any deployment goes into error state intermittently. Should we include Error state after some n reties?

Copy link
Contributor Author

@Pearl1594 Pearl1594 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was my worry too, wanted some inputs on it. I'll do that. Thanks @shwstppr

final List<Integer> results = customSearch(sc, null);
return results.get(0);
}
Expand Down